← Back to issue list

meta: remove remaining `__dict__` and key list usage in snap

View original Github issue

Metadata

Project
snapcraft
Number
#2953
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2953 in commit ef4d64e8d, removing remaining __dict__ and key-list usage from Snap metadata and fixing a Python 3.8 c901 label.

Resolution: closed resolved

Reason: PR #2953 was approved and merged as commit ef4d64e8d, completing the Snap metadata serialization cleanup and applying the c901 label correction.

Evaluated by: mr-cal-bot

No scores available.

Issue body

also fix a c901 label for python 3.8 while I'm in the vicinity.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2953 in commit ef4d64e8d, removing remaining __dict__ and key-list usage from Snap metadata and fixing a Python 3.8 c901 label.
stealth/space-bunny-alpha — closed resolved Merged PR #2953 in commit ef4d64e8d, removing remaining __dict__ and key-list usage in Snap metadata and correcting the Python 3.8 c901 label.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2953 (commit ef4d64e8d), removing remaining __dict__ and key-list usage in snap and correcting a Python 3.8 c901 lint label.
qwen/qwen3.6-35b-a3b — — Merged changes removing remaining __dict__ and key list usage in snap. Also fixed a c901 lint label for Python 3.8. Approved by one reviewer, modifying two files with a net reduction of 20 lines.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes remove remaining __dict__ and key list usage in snap, and fix a c901 lint label for Python 3.8.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2950 (confidence 98%)

    Immediately preceding Snap.to_dict() cleanup that introduced explicit serialization before this follow-up.

Related issues

Issue Project State Summary Similarity
#2821 meta: remove __dict__ usage in Snap snapcraft closed Closed unmerged and superseded by smaller Snap refactor PRs after the author split the broad __dict__ cleanup to ease review.
77%
#2950 meta: Snap to_dict() cleanup snapcraft merged Merged PR #2950 in commit 5934e0009, replacing __dict__-based Snap serialization with explicit properties and moving snap.yaml-specific output into to_snap_yaml_dict().
73%