← Back to issue list

Upload: Obtain name from YAML instead of snap.

View original Github issue

Metadata

Project
snapcraft
Number
#298
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #298 as e96c7b08e, fixing LP #1541353 by reading the snap name from snapcraft.yaml instead of parsing the built snap package.

Resolution: closed resolved

Reason: PR #298 was merged in commit e96c7b08e. Its change replaced fragile snap package parsing with the name declared in snapcraft.yaml, resolving LP #1541353.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR fixes LP: [#1541353](https://bugs.launchpad.net/snapcraft/+bug/1541353) by using the `snapcraft.yaml` to obtain the snap name rather than using regex against the snap package, which was rather fragile and not in accordance with the spec.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #298 as e96c7b08e, fixing LP #1541353 by reading the snap name from snapcraft.yaml instead of parsing the built snap package.
stealth/space-bunny-alpha — closed resolved Merged PR #298 (commit 3c43312af; merge e96c7b08e), fixing LP #1541353 by reading the snap name from snapcraft.yaml instead of parsing the snap package.
stealth/space-bunny-alpha — closed resolved Merged PR #298 in e96c7b08e, fixing LP #1541353 by reading the snap name from snapcraft.yaml instead of regex-parsing the snap package.
stealth/space-bunny-alpha — closed resolved Merged PR #298 (commit 3c43312af, merge e96c7b08e) fixing LP bug #1541353: snapcraft upload now reads the snap name from snapcraft.yaml instead of regex-parsing the .snap package.
stealth/space-bunny-alpha — closed resolved Merged PR #298 as e96c7b08e (implementation 3c43312af), fixing LP #1541353 by reading the name from snapcraft.yaml instead of regex-parsing the snap package.
stealth/space-bunny-alpha — closed resolved Merged PR #298, resolving LP #1541353 by deriving the snap name from snapcraft.yaml instead of parsing the snap package.
qwen/qwen3.6-35b-a3b — — Merged to fix LP #1541353 by retrieving the snap name from snapcraft.yaml instead of fragile regex. Approved after a minor lint fix, with integration confirmed working via the bug's test case.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced fragile regex parsing with direct snapcraft.yaml reading to obtain the snap name, resolving Launchpad bug #1541353 and ensuring spec compliance. Approved after addressing a minor unused variable warning.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft (launchpad)#1541353 (confidence 100%)

    The PR description and merged change explicitly identify this Launchpad bug as fixed by #298.

Related issues

Issue Project State Summary Similarity
#1541353 'snapcraft upload' says 'Invalid package filename.' snapcraft (launchpad) closed Fixed by merged canonical/snapcraft PR #298: upload reads the snap name from snapcraft.yaml instead of parsing the built package.
72%