colcon plugin: rewrite poco absolute library paths
Metadata
Current evaluation
Merged #2981 as e54d90b1b, updating the colcon plugin to rewrite Poco's absolute library paths in usr/lib/cmake and restore ROS Eloquent builds on Ubuntu Bionic.
Resolution: closed resolved
Reason: PR #2981 was approved and merged as commit e54d90b1b, applying the existing CMake path-fixing logic to usr/lib/cmake and fixing LP #1866723.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
The version of poco in Ubuntu Bionic (v1.8.0.1) has a bug where it installs absolute library paths in its cmake target file. ROS Eloquent was updated to inherit those paths, and no longer builds (although Dashing still does). This PR fixes [LP: #1866723](https://bugs.launchpad.net/bugs/1866723) by re-using the existing cmake-fixing logic, but also apply it to the directory containing poco's target file (`usr/lib/cmake`).
Note that this is not as targeted as it could be. I figure this issue may not be unique, so fixing all of `usr/lib/cmake` made sense, but we could keep it to the specific file that's broken as well.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2981 as e54d90b1b, updating the colcon plugin to rewrite Poco's absolute library paths in usr/lib/cmake and restore ROS Eloquent builds on Ubuntu Bionic. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #2981 as e54d90b1b, rewriting absolute library paths in usr/lib/cmake to fix Poco 1.8.0.1 breaking ROS Eloquent builds. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Rewrites absolute library paths in the colcon plugin to fix a cmake bug in Ubuntu Bionic's poco library breaking ROS Eloquent builds. Applies existing path rewriting logic to the usr/lib/cmake directory. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for Ubuntu Bionic's poco v1.8.0.1 cmake bug breaking ROS Eloquent builds. Applied existing cmake path rewriting logic to the usr/lib/cmake directory to resolve absolute library paths in poco target files. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1866723 Colcon plugin: eloquent can't find libpcre or libz | snapcraft (launchpad) | closed | Fixed by merged snapcore/snapcraft#2981 (commit e54d90b1b), which rewrote Poco absolute library paths and restored ROS 2 Eloquent builds. |