← Back to issue list

plugins: move the existing plugin to a new package

View original Github issue

Metadata

Project
snapcraft
Number
#2984
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 38996d538: plugins relocated to a new package with legacy import paths kept working via a PathFinder/Loader added to sys.meta_path, enabling deprecation warnings for custom plugin authors.

Resolution: closed resolved

Reason: PR #2984 was merged into snapcraft as commit 38996d538, carrying out the plugin package move and adding the sys.meta_path PathFinder/Loader shim for backwards compatibility. Tests were migrated to run against both BasePlugin and NilPlugin variants.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Backwards compatibility is kept for plugins that have been moved by adding a PathFinder and Loader implementation to sys.meta_path. This allows warnings to also be implemented for _custom_ plugin authors. Two ensure local plugin using older import paths still work tests have been migrated to spread with two variants with the: - BasePlugin. - NilPlugin Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 38996d538: plugins relocated to a new package with legacy import paths kept working via a PathFinder/Loader added to sys.meta_path, enabling deprecation warnings for custom plugin authors.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#2984 (38996d538), moving plugins to a new package while preserving legacy imports through sys.meta_path.
qwen/qwen3.6-35b-a3b — — Relocates existing plugins to a new package while preserving backwards compatibility via sys.meta_path. Approved and merged after passing CI checks, updating 490 files and migrating spread tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged plugin relocation to a new package, preserving backwards compatibility via a sys.meta_path PathFinder and Loader. Tests were migrated to spread with BasePlugin and NilPlugin variants.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.