← Back to issue list

grammar: pick from properties if attributes not in the plugin

View original Github issue

Metadata

Project
snapcraft
Number
#3045
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged. The change enables v2 support by decoupling user-added properties from plugin operations, allowing the system to pick from properties if attributes are missing. Approved by one reviewer with zero unresolved comments and passing CI checks.

Suggested action: —

No scores available.

Issue body

This enables support for v2 which decouples user added properties (build-packages, stage-packages, build-snaps and stage-snaps) and the ones the plugin needs to operate. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged. The change enables v2 support by decoupling user-added properties from plugin operations, allowing the system to pick from properties if attributes are missing. Approved by one reviewer with zero unresolved comments and passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged to enable v2 grammar support. The change decouples user-defined properties from plugin-required attributes, allowing plugins to fall back to properties when attributes are missing.
qwen3.6-35b-a3b-mtp-q6 — — Merged by maintainer sergiusens. Enables v2 grammar support by decoupling user-defined properties from plugin-required attributes, allowing fallback to properties when plugin attributes are absent.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#22 plugins: add plugin and plugin properties base classes craft-parts merged Merged: introduces base classes for the plugin subsystem and plugin properties. Approved by three reviewers, passed CI checks, and added 227 lines across six files to define part source building with optional plugin-specific properties.
72%