← Back to issue list

plugins v2: update plugins so they have a similar behavior

View original Github issue

Metadata

Project
snapcraft
Number
#3070
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after reviewer approval and passing CI. Standardized plugin behavior by removing invalid minitems usage, eliminating prefix setup and default build type concepts, and correcting docstring formatting across 13 files.

Suggested action:

No scores available.

Issue body

- Remove invalid uses of minitems (and not minItems) in the plugin schemas. - Remove use of any "prefix" setup, it is up to the developer of the snap to pick. - Remove the concept of setting a default build type for plugins. - Fixup the docstrings so they are consistent with spacing and general presentation. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after reviewer approval and passing CI. Standardized plugin behavior by removing invalid minitems usage, eliminating prefix setup and default build type concepts, and correcting docstring formatting across 13 files.
qwen3.6-35b-a3b-mtp-q6 Merged changes standardize plugin behavior by removing invalid minitems schema keywords, eliminating automatic prefix setup and default build types, and correcting docstring formatting for consistency.
qwen3.6-35b-a3b-mtp-q6 Successfully merged changes standardizing plugin v2 behavior by removing invalid minitems usage, eliminating prefix setup and default build types, and correcting docstring formatting.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1181 docs: remove instances of 'v2' from plugin intros rockcraft merged Merged documentation update removing deprecated 'v2' references from plugin introspection and renaming the plugin index to Plugins. Approved by three reviewers, passed CI checks, and applied across three files.
76%
#1540 docs: reduce instances of 'v2' in plugin references craft-parts open Documentation cleanup removing 'v2' from plugin references across 2 files (+6/-6 lines). Approved by 2 reviewers with 1 unresolved comment; CI passing.
75%
#3037 plugins: introduce v2.CMakePlugin snapcraft merged Merged introduction of v2.CMakePlugin and consolidation of the v2 plugin spread test suite to streamline future development. Approved by one reviewer, passed CI, and modified 16 files with 196 additions and 23 deletions.
74%
#5809 docs: format plugin references snapcraft merged Merged documentation updates standardizing plugin reference formatting. Changes replace Keywords with Keys, align whitespace, standardize list formatting, and update the Maven example. Approved by two reviewers and passed CI checks.
72%
#1349 docs: normalise plugin references craft-parts merged Documentation references for plugins were normalized across 30 files by standardizing whitespace, headings, and formatting roles. The changes were approved by two reviewers, passed all CI checks, and successfully merged.
72%
#3389 plugins v1: move build base test in v1 plugins to base class snapcraft merged Merged refactoring that moves build base validation to the V1 plugin base class constructor. The change reduces duplication across 23 files while maintaining checks for core, core16, and core18 bases.
71%
#3032 plugins: introduce v2.MakePlugin with rebuilding snapcraft merged Merged introduction of v2.MakePlugin with rebuilding support and proper environment setup. Approved by one reviewer, the change updates 23 files (+379/-92 lines).
71%