← Back to issue list

plugins: break out rosdep resolve parsing for external use

View original Github issue

Metadata

Project
snapcraft
Number
#3095
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged. Extracted rosdep resolve parsing logic for external use by the colcon v2 plugin. Approved by one reviewer, passed CI checks, and modified one file (+34/-27).

Suggested action:

No scores available.

Issue body

The colcon v2 plugin may call this directly, at least temporarily. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Extracted rosdep resolve parsing logic for external use by the colcon v2 plugin. Approved by one reviewer, passed CI checks, and modified one file (+34/-27).
qwen3.6-35b-a3b-mtp-q6 Merged. Extracts rosdep resolve parsing logic for external use, enabling direct calls by the colcon v2 plugin. Integrated without comments or revisions.
qwen3.6-35b-a3b-mtp-q6 Merged. Extracts rosdep resolve parsing logic for external reuse, enabling the colcon v2 plugin to invoke it directly.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2456 plugins: add colcon plugin snapcraft merged Merged the colcon plugin for ROS2 builds, resolving LP: #1805213. Added as a beta feature, the change was approved by two reviewers, passed CI with 100% diff coverage, and introduced 2120 lines across 16 files.
75%
#3566 ROS 2 plugins v2 misc fixes snapcraft merged Merged after resolving conflicts and passing CI. Fixes ROS 2 plugins v2 by updating the colcon install path, resolving local packages during staging by removing the COLCON_IGNORE marker, and adding spread tests.
74%
#3536 ROS plugins v2 misc fixes snapcraft merged Merged. Fixes ROS plugins v2 staging failures by checking local ROS directories and skipping rosdep resolution for locally available packages. Updated tests for core20. Approved by two reviewers and passed CI.
73%
#3664 ROS plugins v2: respect source-subdir key snapcraft merged Merged. Updates ROS plugins v2 to respect the source-subdir key, removes an unnecessary catkin_tools dependency, and adds tests for Colcon and catkin v2 subdir handling. Approved by reviewers and passed CI.
73%
#3994 core22 colcon plugin: re-source environment after installation snapcraft merged Merged fix for core22 colcon plugin that re-sources ROS 2 environment post-installation to resolve custom interface build failures. Added spread tests and package state restoration. Approved by two reviewers and merged.
70%