← Back to issue list

pcache: introduce persistent cache decorator

View original Github issue

Metadata

Project
snapcraft
Number
#3109
Type
pull request
State
closed
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Persistent cache decorator PR #3109 was closed unmerged after prolonged inactivity; no design spec, review, CI, or merged pcache implementation followed.

Resolution: closed stale

Reason: The PR received no reviews or CI and remained inactive for years after a maintainer requested a design spec. No implementation or superseding work was found.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Cache results of wrapped function, returning the last known-good result, if available. Configurable expiration times may be set, with a default of one-day. The recorded items have an identity key derived from: - function name - function arguments - function keyword arguments All arguments to the wrapped function must be representable via repr(). The arguments must be represented in an uniquely identifiable and repeatable manner to ensure accuracy and prevent collisions. Note that this current implementation is not optimized for performance. The database is opened and closed on-demand which carries a cost. It could be updated to keep the database open across the lifetime of the process, but that may complicate usage with multiple processes (e.g. snapcraftctl). For our current use cases, this is the safe and appropriate default. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Persistent cache decorator PR #3109 was closed unmerged after prolonged inactivity; no design spec, review, CI, or merged pcache implementation followed.
stealth/space-bunny-alpha — closed stale Persistent-cache decorator PR #3109 was closed unmerged after six years of inactivity; no design spec, CI, review, or replacement implementation followed.
stealth/space-bunny-alpha — closed stale Persistent-cache decorator PR #3109 was closed unmerged after prolonged inactivity, with no reviewers or CI; the requested design spec was not produced.
qwen/qwen3.6-35b-a3b — — A persistent cache decorator was proposed but closed without merging. Reviewers requested a design spec and questioned the implementation approach, leaving the contribution abandoned.
qwen3.6-35b-a3b-mtp-q6 — — Closed without merging. A maintainer requested a design spec, and the pull request was abandoned pending further documentation.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.