spread: remove dead code for lxd setup and add debug prints
Metadata
Current evaluation
Merged removal of redundant elif dead code in LXD setup logic and addition of debug prints for LXD snap install failures. Approved by one reviewer, passed CI checks, and integrated.
Suggested action: —
No scores available.
Issue body
The elif was effectively evaluated by the prior if.
Add some debug logic too to help solve some random lxd snap
install failures.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of redundant elif dead code in LXD setup logic and addition of debug prints for LXD snap install failures. Approved by one reviewer, passed CI checks, and integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes removing dead code in the LXD setup logic and adding debug prints to diagnose LXD snap installation failures. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Successfully merged. Removes dead LXD setup code where an elif was redundantly evaluated by a preceding if. Adds debug prints to troubleshoot LXD snap installation failures. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2983 tests: add LXD spread test | snapcraft | merged | Merged after reviewer approval and passing CI checks. Added LXD spread test to verify LXD builds and installs. Modified two files with 29 added lines. | |
| #1771 lxd: suppress traceback when lxc launch / init fails | snapcraft | merged | Merged to suppress tracebacks when lxc launch or init fails, relying on lxc's native error output. Approved by one reviewer, modifying three files (+35/-15). | |
| #1984 fix(snap): check if LXD is actually installed | charmcraft | merged | Merged fix updating configure and remove hooks to verify LXD installation before proceeding. Prevents unwanted LXD snap installations on Ubuntu that cause delays. Approved by two reviewers, passed CI, and resolves #1982. | |
| #1647 lxd: better surfacing of errors | snapcraft | merged | Merged. Resolves duplicate error printing in LXD by having callers return silent errors with proper exit codes, allowing callees to handle message display. Approved and merged after CI validation. | |
| #3281 build providers: hide systemd setup for LXD | snapcraft | merged | Merged to hide verbose systemd setup output for LXD build providers. Approved by one reviewer, passed CI, and modified two files to streamline console output while preserving internal debug visibility. | |
| #2222 lxd: support new style snap injection | snapcraft | merged | Merged after implementing new style snap injection for LXD. Refactored provider logic, normalized code, and removed test duplication. Approved by two reviewers, passed CI, and verified via edge channel testing. | |
| #1677 ci: don't install lxd | craft-parts | merged | Merged a CI configuration update removing the unused LXD installation. Approved by three reviewers, the change was integrated despite unrelated test failures stemming from a Launchpad issue. | |
| #1516 lxd: LXD not installed when using remote | snapcraft | merged | Merged fix for a bug where lxc installation was not correctly verified when using a LXD remote. Also corrected incomplete test scenario usage. Approved by two reviewers, modified two files. | |
| #2631 spread tests: enable LXD build provider tests | snapcraft | merged | Merged into master. Enabled LXD build provider tests by relocating setup to the early prepare phase to reduce overhead and consolidating declarations from task.yaml to spread.yaml. Approved, passed CI, and increased coverage by 0.01%. | |
| #3957 tests: retry installing lxd snap | snapcraft | merged | Merged into main. Introduces retry logic for LXD snap installation in tests via snapd-testing-tools to workaround an intermittent snapd bug. Approved, passed CI, and caused no coverage changes. |