spread tests: improvements for python-hello-with-stage-package-dep
Metadata
Current evaluation
Merged #3121 in commit 440b0ce52, adding appdirs and build-time PYTHONPATH handling to the Python stage-package dependency spread test.
Resolution: closed resolved
Reason: PR snapcore/snapcraft#3121 was approved and merged as commit 440b0ce52, improving the stage-package dependency test to use staged dependencies during the build.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- Add 'appdirs' to install_requires.
- Set PYTHONPATH which will incorporate the stage-packages at build-time. Otherwise pip will fetch and install these dependencies separately.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3121 in commit 440b0ce52, adding appdirs and build-time PYTHONPATH handling to the Python stage-package dependency spread test. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3121 in commit 440b0ce52, improving the stage-package dependency spread test by adding appdirs and setting PYTHONPATH during the build. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3121 (commit 440b0ce52) improved the python-hello-with-stage-package-dep spread test: added 'appdirs' to install_requires and set PYTHONPATH so stage-packages are used at build time instead of pip fetching deps. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3121 in commit 440b0ce52, adding appdirs and setting PYTHONPATH so spread tests use stage packages instead of installing dependencies separately. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged test improvements for python-hello-with-stage-package-dep. Added appdirs to install_requires and set PYTHONPATH to use stage-packages at build-time, avoiding redundant pip installs. Approved and merged with a +3/-0 diff across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvements to spread tests for python-hello-with-stage-package-dep. Added appdirs to install_requires and set PYTHONPATH to use stage-packages at build-time, preventing redundant pip installations. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3674 spread: fix python-hello | snapcraft | merged | Merged PR #3674 (commit 62d65df) fixed the python-hello spread-test setup for setuptools 61.1.0 package discovery. | |
| #3670 spread: fix python-hello | snapcraft | merged | PR #3670 merged into main as d59a4c459, adjusting two python-hello test fixtures to handle setuptools 61.1.0 package discovery and restore the affected spread tests. |