storeapi: update api and error messages from push to upload
Metadata
Current evaluation
Merged updates to the storeapi module replacing push terminology with upload in API calls and error messages. Approved by one reviewer, modifying 10 files with 126 additions and 146 deletions.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged updates to the storeapi module replacing push terminology with upload in API calls and error messages. Approved by one reviewer, modifying 10 files with 126 additions and 146 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged update to the storeapi module, replacing push terminology with upload across API endpoints and error messages. The change was integrated by maintainer sergiusens. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged pull request updating the storeapi module to replace push terminology with upload in API calls and error messages. Integrated without additional discussion. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1261 storeapi: improve the error message for the case the Store answers an upload needs manual review. | snapcraft | merged | Merged an update to the storeapi error message for uploads requiring manual review. The text was updated to reference the community forum. A proposed test for the constant was declined as unnecessary, and the change was approved and merged. | |
| #2749 storeapi: add StoreErrorList to handle store errors | snapcraft | merged | Added StoreErrorList class to centralize store error handling. Updated StorePushError to correctly parse resource-not-found and resource-forbidden responses, displaying clear user messages. Merged after reviewer approval, changing six files (+106/-42). | |
| #3667 storeapi: fix typo | snapcraft | merged | Merged a single-line typo correction in the storeapi module. Approved by a reviewer, passed CI, and increased test coverage by 0.07%. | |
| #3550 storeapi: log responses and registration error code | snapcraft | merged | Merged. Adds debug logging for store API responses and improves registration error code output. The minimal change (+16/-5 lines, 4 files) passed CI, achieved 100% coverage, and was approved for backporting. | |
| #3311 storeapi: add releases endpoint | snapcraft | merged | Merged after approval, adding a releases endpoint to the storeapi. Changes span 8 files with 550 additions and 11 deletions. Author noted ignoring an unrelated electron builder test failure. | |
| #3272 storeapi: improve to channel map docstrings | snapcraft | merged | Merged updates to storeapi channel map docstrings, aligning them with PEP 257 guidelines. Approved by one reviewer with no unresolved comments. The change affects one file, reducing 19 lines and adding 7. | |
| #2116 storeapi: handle 5xx error codes for all store endpoints | snapcraft | merged | Merged robust 5xx error handling across all store API endpoints. Fixes Launchpad bug #1768370 by generalizing release-specific error handling. Approved by two reviewers and passed CI checks. | |
| #750 storeapi: remove dependency on the 'success' attr | snapcraft | merged | Merged to remove the 'success' attribute dependency in storeapi, resolving LP: #1615786 and LP: #1611116. Approved by kyrofa, the update modifies 6 files with +75/-37 lines. | |
| #3378 storeapi: allow revision entries without a base set | snapcraft | merged | Merged changes to storeapi that allow revision entries without a base set. Approved by one reviewer, the update modifies three files (+14/-10) to resolve LP #1904197. | |
| #2094 storeapi: better handle network errors and retries | snapcraft | merged | Resolves Launchpad bug #1765671 by improving storeapi network error handling. Sets urllib log level to ERROR and properly manages max retry failures, eliminating verbose warnings and tracebacks. Approved and merged after passing CI. |