cli: migrate close to use the new channel map
Metadata
Current evaluation
Merged as commit 19393ef36: PR #3143 migrated close to the new channel-map implementation, fixing progressive-release channel reporting and skipping unreliable closed_channels results.
Resolution: closed resolved
Reason: PR #3143 is marked merged and appears in repository history as commit 19393ef36. It moved close logic into the CLI’s channel-map implementation, making channel display progressive-release aware and avoiding incorrect closed_channels results.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The implementation was moved to the CLI as being done for all commands.
With this, the new implementation for displaying a channel map is used,
which avoids the bug in the channel_map_tree returned in close that is
not progressive release aware and shows channels mistakenly as open.
The closed_channels API results are skipped as well as they are not
really track aware, returning mixed results for tracks in some scenarios
and plain risks for others (when latest is used, which is not allowed
when using more than one track).
The tests have been simplified to the concerns of the close CLI results
as display variants of the channel map tree are already done under test_status.
A missing todo checklist entry was added to take care of the upload logic.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 19393ef36: PR #3143 migrated close to the new channel-map implementation, fixing progressive-release channel reporting and skipping unreliable closed_channels results. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3143 merged (commit 19393ef36), migrating the CLI 'close' command to the new channel map implementation, fixing wrong open-channel reporting and skipping non-track-aware closed_channels API results. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3143 merged into master, migrating close to the new CLI channel map. It restores progressive-release awareness, preventing channels from being mistakenly shown as open, and adds a TODO for upload logic. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged migration of the close CLI command to the new channel map. Fixed a bug where channels were incorrectly shown as open due to missing progressive release awareness. Simplified tests, added a TODO for upload logic, and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged migration of the close CLI command to a new channel map implementation. Fixes a bug where channels were incorrectly shown as open due to missing progressive release awareness. Tests simplified, problematic API results skipped, and upload logic TODO added. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3145 cli: migrate upload and release to new channel-map | snapcraft | merged | Merged #3145 in commit 01b4645a8, migrating the upload and release CLI commands to the new Store channel-map API. | |
| #847 Implementing channel-closing. | snapcraft | merged | Merged PR #847 implemented channel-closing: the close API now returns closed channels and channel maps across snap architectures, resolving LP #1615764 (commit 36a572685). | |
| #2916 status: implement using the new channel-map endpoint | snapcraft | closed | Draft PR #2916 (status via new channel-map endpoint, +1794/-734) was closed unmerged after ~5 years with 15 unresolved review comments; the work landed via #3004 and #3008 (commit 70c7edb3b). |