cli: restore --target-arch with warning for LXD and Multipass
Metadata
Current evaluation
Closed without merging due to unresolved review comments and missing CI checks. The change intended to restore the --target-arch flag for LXD and Multipass, converting an error to a warning.
Suggested action: —
No scores available.
Issue body
Electron builder currently uses --target-arch. Until fixes are
upstreamed, restore --target-arch availability for LXD and Multipass,
replacing the error with a warning.
Pops target_arch from kwargs to prevent usage by get_project(),
which is not aware of the build provider.
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging due to unresolved review comments and missing CI checks. The change intended to restore the --target-arch flag for LXD and Multipass, converting an error to a warning. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to restore --target-arch for LXD and Multipass, replacing the error with a warning until upstream fixes land. The change isolates target_arch from get_project() kwargs to prevent unintended usage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Restores the --target-arch CLI flag for LXD and Multipass, replacing a hard error with a warning. The flag is stripped from kwargs to prevent unintended usage by get_project(). |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3175 cli: restore --target-arch with warning for LXD and Multipass | snapcraft | merged | Restored the --target-arch CLI flag with a warning for LXD and Multipass. Merged after single reviewer approval with minimal changes across two files. | |
| #3152 cli: disable --target-arch for multipass/lxd | snapcraft | merged | Merged changes disabling the --target-arch CLI flag for multipass and LXD. The flag was non-functional and misleading, so it was removed to prevent confusion while future architecture targeting is developed. Approved and passed CI. | |
| #1866 lxd: setup LXD remote for multipass | snapcraft | closed | Closed without merging. The change auto-configured an LXD remote for multipass but hit unresolved permission and mounting errors. Reviewers flagged inconsistent behavior, prompting closure pending fixes. |