← Back to issue list

cli: restore --target-arch with warning for LXD and Multipass

View original Github issue

Metadata

Project
snapcraft
Number
#3172
Type
pull request
State
closed
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged; its change landed as #3175 (commit b29e100eb), restoring --target-arch for LXD/Multipass with a warning, followed by fix #3181 (9346aa623).

Resolution: closed superseded

Reason: The identical change was submitted again as snapcraft#3175 and merged as commit b29e100eb, adding a warning instead of an error when --target-arch is used with LXD/Multipass and popping target_arch before get_project(). A follow-up, #3181 (9346aa623), suppressed spurious warnings when target_arch was None.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Electron builder currently uses --target-arch. Until fixes are upstreamed, restore --target-arch availability for LXD and Multipass, replacing the error with a warning. Pops target_arch from kwargs to prevent usage by get_project(), which is not aware of the build provider. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged; its change landed as #3175 (commit b29e100eb), restoring --target-arch for LXD/Multipass with a warning, followed by fix #3181 (9346aa623).
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#3175 (b29e100eb), restoring --target-arch for LXD and Multipass with a warning; follow-up #3181 fixed warnings when the option was unset.
stealth/space-bunny-alpha — closed resolved Merged as b29e100eb (#3175), restoring --target-arch for LXD and Multipass with a warning and preventing target_arch from reaching get_project().
qwen/qwen3.6-35b-a3b — — Closed without merging due to unresolved review comments and missing CI checks. The change intended to restore the --target-arch flag for LXD and Multipass, converting an error to a warning.
qwen3.6-35b-a3b-mtp-q6 — — Merged to restore --target-arch for LXD and Multipass, replacing the error with a warning until upstream fixes land. The change isolates target_arch from get_project() kwargs to prevent unintended usage.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3175 (confidence 95%)

    Same title/scope; merged as commit b29e100eb and is the commit that landed this PR's diff.

  • Related To: canonical/snapcraft#3181 (confidence 90%)

    Follow-up merge (9346aa623) fixing warnings emitted when target_arch was unset.

  • Caused By: canonical/snapcraft#3151 (confidence 55%)

    Earlier commit 8942d89d2 disabled --target-arch on core20, prompting this restore-with-warning.

  • Related To: canonical/snapcraft#3152 (confidence 50%)

    Commit 2dd5e5d1e disabled --target-arch for multipass/lxd, the behaviour this work partially reverts for LXD/Multipass.

Related issues

Issue Project State Summary Similarity
#3175 cli: restore --target-arch with warning for LXD and Multipass snapcraft merged Merged in #3175 (b29e100eb), restoring --target-arch while warning that architecture targeting is unsupported for LXD and Multipass.
95%
#3152 cli: disable --target-arch for multipass/lxd snapcraft merged PR #3152 merged as commit 2dd5e5d1e, hiding/disabling the --target-arch option for Multipass and LXD builds because it had no effect; follow-up PR #3175 later restored it with a deprecation warning.
82%