repo: consider virtual pkgs for cache invalidation
Metadata
Current evaluation
Merged PR #3177 via commit 5aec00445, making cache invalidation account for virtual build packages, warning against them, and refactoring AptCache logic.
Resolution: closed resolved
Reason: The pull request was merged as commit 5aec00445. It resolves virtual build packages during cache invalidation and warns when they could compromise deterministic builds.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Virtual packages were not considered when checking if all build-packages
are satisfied between runs. Check and resolve with a warning to avoid
use of virtual packages for deterministic results.
Logic has shifted a bit to avoid exposing more functionality from
AptCache and have a nicer separation of concerns.
LP: #1883546
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3177 via commit 5aec00445, making cache invalidation account for virtual build packages, warning against them, and refactoring AptCache logic. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3177 (commit 5aec00445) made cache invalidation account for virtual build packages, warned against their use, and refactored AptCache logic. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3177 as commit 5aec00445, fixing cache invalidation to account for virtual build packages and warning against them for deterministic results. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3177 as commit 5aec00445, making cache invalidation consider virtual build packages and warning against them for deterministic results; AptCache logic was refactored. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates cache invalidation to include virtual packages, adding a warning to discourage their use for deterministic builds. Refactors AptCache logic for better separation of concerns. Approved by one reviewer and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to fix cache invalidation by accounting for virtual packages, preventing non-deterministic builds. Refactored logic to avoid exposing AptCache internals and improve separation of concerns. Resolves LP: #1883546. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #43 packages: add support to apt cache operations | craft-parts | merged | Merged PR #43 via 115ae066, adding APT cache operations for package retrieval. Implementation commit: 3ee0c477. |