← Back to issue list

build providers: check revision before switching

View original Github issue

Metadata

Project
snapcraft
Number
#3184
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #3184 as 2616ab456, adding a revision check before build providers switch channels and preventing unintended channel switches.

Resolution: closed resolved

Reason: PR #3184 was merged at commit 2616ab456. It now verifies the installed snap revision before switching the build-provider snap channel.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Snapcraft was switching channels on the availability of a tracking channel, it may be that this was incorrectly implemented or that snapd now switched to always report a tracking-channel when installing a snap with --dangerous after previously having installed a revision from the Snap Store. An additional check for revision is now enforced before setting the switch. LP: #1884576 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #3184 as 2616ab456, adding a revision check before build providers switch channels and preventing unintended channel switches.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#3184 (commit 2616ab456), adding a revision check before build providers switch channels.
stealth/space-bunny-alpha — closed resolved Merged PR #3184 (2616ab456) now checks the installed revision before build providers switch channels, preventing unintended channel changes.
qwen/qwen3.6-35b-a3b — — Merged a fix adding a revision check before channel switching in build providers. Resolves incorrect switching behavior caused by snapd changes. Approved by reviewer, passed CI, and merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix enforcing a revision check before channel switching in build providers. Resolves incorrect channel switching when installing snaps with --dangerous. Closes LP: #1884576.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3146 (confidence 95%)

    Merged predecessor c15f0623d introduced channel switching during build-provider snap injection; #3184 tightened that behavior.

Related issues

Issue Project State Summary Similarity
#3146 build providers: snap sw to channels if injecting snapcraft merged Merged PR #3146 as commit c15f0623d, preventing revision-asserted injected snaps from being switched to latest/stable and preserving their intended tracking channels.
73%