← Back to issue list

cli: unset false boolean flags in environment

View original Github issue

Metadata

Project
snapcraft
Number
#3196
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#3196 (c1a41fd84), leaving false boolean CLI environment variables unset so downstream flag checks can use simple presence tests.

Resolution: closed resolved

Reason: PR #3196 was merged as commit c1a41fd84. It ensures boolean environment variables are set only when true, simplifying option-flag checks.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This simplifies checks for various option flags by ensuring the environment variable is only set when true. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#3196 (c1a41fd84), leaving false boolean CLI environment variables unset so downstream flag checks can use simple presence tests.
stealth/space-bunny-alpha — closed resolved Merged PR #3196 (commit c1a41fd84), leaving environment variables unset for false boolean CLI flags so checks can rely on presence.
stealth/space-bunny-alpha — closed resolved Merged #3196 (commit c1a41fd84), leaving false boolean CLI options unset in the environment so flag checks can use a simple presence test.
qwen/qwen3.6-35b-a3b — — Merged to unset false boolean flags in the environment, simplifying option flag checks. Approved by one reviewer, passed CI, and modified one file (+15/-2).
qwen3.6-35b-a3b-mtp-q6 — — Merged a change that unsets false boolean flags in the environment to simplify option flag checks. Environment variables are now only set when true, streamlining CLI configuration handling.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.