← Back to issue list

build providers: use PEP-440 compliant version comparison operator

View original Github issue

Metadata

Project
snapcraft
Number
#3215
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged updates to build providers, replacing manual version checks with pkg_resources for PEP-440 compliance. Approved by reviewer, passed CI, and modified one file (+5/-10).

Suggested action:

No scores available.

Issue body

Now that we're using PEP-440 compliant versioning, use the version objects provided by pkg_resources for comparison. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged updates to build providers, replacing manual version checks with pkg_resources for PEP-440 compliance. Approved by reviewer, passed CI, and modified one file (+5/-10).
qwen3.6-35b-a3b-mtp-q6 Merged update to build providers for PEP-440 compliant version comparison using pkg_resources. The change aligns version handling with the new project versioning scheme and was approved without comments.
qwen3.6-35b-a3b-mtp-q6 Merged. Updated build providers to use pkg_resources version objects for PEP-440 compliant comparison, replacing legacy operators to align with the project's standardized versioning scheme.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2474 build providers: remove dead code snapcraft merged Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines).
73%
#5537 docs: update build provider procedures snapcraft merged Merged documentation update to build provider procedures, resolving issue #5519. Approved by two reviewers and passed most CI checks despite minor integration test failures. Changes span four files with 100 lines added and 98 removed.
73%
#2275 build providers: use the provider if exported snapcraft merged Merged an update to build provider logic that enables using a provider if it is exported. Approved by a reviewer, passed CI checks, and integrated into the codebase.
71%
#2810 build-providers: address errors from mypy uprev snapcraft merged Merged after approval. Addresses type-checking errors in the build-providers module caused by a mypy version upgrade. The changes modify six files, adding 117 lines and removing 48.
70%
#2940 build providers: remove use of cloud-init snapcraft merged Merged changes removing cloud-init from build providers. Refactored to use _run and _push_file methods, isolating initial setup. Approved by reviewer, passed CI, and updated six files.
70%
#2508 Build provider errors snapcraft merged Merged after approval and passing CI checks. Resolved build provider errors across two files (+353/-85 lines). Codecov reported 90.62% diff coverage.
70%