cmake v2 plugin: add stage to CMAKE_PREFIX_PATH
Metadata
Current evaluation
Merged #3217 in commit 66ed449b8, adding the stage directory to cmake v2's CMAKE_PREFIX_PATH and migrating its unit tests to pytest.
Resolution: closed resolved
Reason: PR #3217 was approved and merged as commit 66ed449b8, resolving CMake-based core20 snap portability failures by exposing staged dependencies through CMAKE_PREFIX_PATH.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Also update the unit tests to use pytest.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Done as noted on https://forum.snapcraft.io/t/porting-cmake-based-core18-snap-to-core20-snap-fails/18647/5 by @jhenstridge
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3217 in commit 66ed449b8, adding the stage directory to cmake v2's CMAKE_PREFIX_PATH and migrating its unit tests to pytest. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3217 in commit 66ed449b8: cmake v2 now includes the stage directory in CMAKE_PREFIX_PATH; unit tests were migrated to pytest. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to the cmake v2 plugin that add a stage to CMAKE_PREFIX_PATH, fixing core18 to core20 snap porting. Unit tests were updated to pytest. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to the cmake v2 plugin that add the stage directory to CMAKE_PREFIX_PATH, resolving core20 snap porting issues. Unit tests were also updated to pytest. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.