cmake v2 plugin: add stage to CMAKE_PREFIX_PATH
Metadata
Current evaluation
Merged changes to the cmake v2 plugin that add a stage to CMAKE_PREFIX_PATH, fixing core18 to core20 snap porting. Unit tests were updated to pytest. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
Also update the unit tests to use pytest.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Done as noted on https://forum.snapcraft.io/t/porting-cmake-based-core18-snap-to-core20-snap-fails/18647/5 by @jhenstridge
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes to the cmake v2 plugin that add a stage to CMAKE_PREFIX_PATH, fixing core18 to core20 snap porting. Unit tests were updated to pytest. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to the cmake v2 plugin that add the stage directory to CMAKE_PREFIX_PATH, resolving core20 snap porting issues. Unit tests were also updated to pytest. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added the stage directory to CMAKE_PREFIX_PATH in the cmake v2 plugin to resolve core20 snap build failures. Unit tests were also migrated to pytest. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2399 cmake plugin: use build snaps to search paths | snapcraft | merged | Merged. Updated the cmake plugin to use build snaps for path searching. Approved by a reviewer with 96.29% diff coverage across two files (+155/-13 lines). | |
| #3154 cmake v2 plugin: take source-subdir into account | snapcraft | merged | Merged. Updates cmake v2 plugin to use SNAPCRAFT_PART_SOURCE_WORK instead of SNAPCRAFT_PART_SOURCE for pull and build steps, fixing source subdirectory handling. Approved, passed CI, and modified 10 files (+55/-7). | |
| #267 plugins: drop cmake install prefix argument | craft-parts | merged | Merged. Removed the default CMAKE_INSTALL_PREFIX from the cmake plugin to fix core22 snap compatibility. Authors must manually specify the prefix for core18 alignment, resolving binary path and library detection issues. | |
| #3123 cmake v2 plugin: configure with $SNAPCRAFT_PART_SRC | snapcraft | merged | Merged a fix updating the cmake v2 plugin to configure via $SNAPCRAFT_PART_SRC. This resolves build failures for projects verifying distinct source and build directories. Approved by one reviewer and passed CI checks. |