← Back to issue list

extensions: kde-neon: use gtk3 platform theme on gtk-based DE's

View original Github issue

Metadata

Project
snapcraft
Number
#3226
Type
pull request
State
merged
Author
merlijn-sebrechts
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3226 in commit 7775fe804, making the KDE Neon extension use the GTK3 platform theme on GTK desktops and enable portal-based native file choosers.

Resolution: closed resolved

Reason: The approved pull request was merged as commit 7775fe804, adding GTK3 platform-theme behavior to the KDE Neon extension.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR makes the KDE neon extension default to using the `gtk3` platform theme on GTK based desktops. This also enables the file chooser portal on those desktops, providing a completely native file chooser for the apps which support it. The `kde-frameworks-*` platform snaps currently do not ship the `gtk3` platform theme or `QGnomePlatform`. This is not an issue, however, because Qt will fallback to `QGnomeTheme`, which is a builtin theme and is always available. > Note: `QGnomeTheme` will use Xorg and XWayland to get theme info, so there are no additional connections required for snaps using it. I'm still trying to figure out what the best way is to provide the `gtk3` platform themes to the snaps. Either I add them to the KDE-frameworks platform snaps, or I create a separate snap which is only installed on GTK3-based desktops (maybe `snapd-desktop-integration` could play a role here?). Even without that, however, this PR is still very useful because the builtin `QGnomeTheme` already looks a lot more native on GTK-based desktops, the use of desktop portals further increase the native look and snaps which manually ship one of the `gtk3` themes gain the full benefits of it.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3226 in commit 7775fe804, making the KDE Neon extension use the GTK3 platform theme on GTK desktops and enable portal-based native file choosers.
stealth/space-bunny-alpha — closed resolved Merged PR #3226 in commit 7775fe804, making the KDE Neon extension use the GTK3 platform theme on GTK desktops and enabling the native file chooser portal.
stealth/space-bunny-alpha — closed resolved PR #3226 merged (commit 7775fe804) making the kde-neon extension default to the gtk3 Qt platform theme on GTK-based desktops, enabling the native file chooser portal. Approved by sergiusens after testing.
stealth/space-bunny-alpha — closed resolved Merged PR #3226 via commit 7775fe804, making KDE Neon use GTK3 theming on GTK desktops and enabling the native file chooser portal.
stealth/space-bunny-alpha — closed resolved Merged PR #3226 in commit 7775fe804: KDE neon snaps now default to GTK3 theming on GTK desktops, enabling portal-based file choosers with QGnomeTheme fallback.
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#3226 (7775fe804), making the KDE neon extension default to the GTK3 platform theme on GTK desktops and enabling the native file chooser portal.
stealth/space-bunny-alpha — closed resolved Merged PR #3226 in commit 7775fe804: kde-neon now defaults to the gtk3 platform theme on GTK desktops, enabling the file chooser portal and falling back to QGnomeTheme.
qwen/qwen3.6-35b-a3b — — Merged KDE neon extension updates to default to the gtk3 platform theme on GTK desktops. Enables native file chooser portal and improves theming via QGnomeTheme fallback. Approved and verified by reviewers.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to the KDE neon extension, defaulting to the gtk3 platform theme on GTK desktops and enabling native file choosers via portals. Qt apps fall back to the built-in QGnomeTheme. Approved and tested by maintainer.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2755 extensions: kde-neon: add icon and sound themes snapcraft merged Merged PR #2755 (commit 8c2c58370) adds gtk-common-themes content snap plugs to the kde-neon extension, fixing pixelated cursors for Qt/KDE apps on stock Ubuntu. Approved by hsitter, described by maintainers as a temporary measure.
80%
#4060 extensions: fix neon-extension issues for core22 snapcraft merged Merged PR #4060 as commit bef32e264, fixing KDE Neon extension compatibility with core22 by restoring the command chain, removing bindtextdomain, and updating SDK matching, part names, and tests.
70%