← Back to issue list

storeapi: reduce the mccabe complexity

View original Github issue

Metadata

Project
snapcraft
Number
#323
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged to reduce McCabe complexity in the storeapi module. The change modified three files, adding 89 and removing 78 lines. Approved by sergiusens, the author indicated subsequent work to replace static checks with flake8.

Suggested action: —

No scores available.

Issue body

LP: #1541011

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged to reduce McCabe complexity in the storeapi module. The change modified three files, adding 89 and removing 78 lines. Approved by sergiusens, the author indicated subsequent work to replace static checks with flake8.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to reduce McCabe complexity in the storeapi module. Approved by a maintainer, the refactoring successfully lowers cyclomatic complexity without altering functionality.
qwen3.6-35b-a3b-mtp-q6 — — Merged refactoring that reduces McCabe complexity in the storeapi module. Approved by sergiusens and resolves Launchpad bug #1541011. The changes improve code maintainability and static analysis compliance.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3667 storeapi: fix typo snapcraft merged Merged a single-line typo correction in the storeapi module. Approved by a reviewer, passed CI, and increased test coverage by 0.07%.
72%
#3442 storeapi: reduce the amount of constants and their meaning snapcraft merged Merged after review and CI approval. Simplified storeapi URL constants to root URLs only, using full endpoint paths directly. Renamed constants for backend alignment, reducing 55 lines across 13 files.
71%
#3550 storeapi: log responses and registration error code snapcraft merged Merged. Adds debug logging for store API responses and improves registration error code output. The minimal change (+16/-5 lines, 4 files) passed CI, achieved 100% coverage, and was approved for backporting.
71%