meta: write stubs for command-chain using hooks when needed
Metadata
Current evaluation
Merged #3296 in commit 95225991f, adding Snapcraft metadata generation of stub hooks for command-chain-based hooks.
Resolution: closed resolved
Reason: PR #3296 was approved and merged as commit 95225991f, implementing hook stub generation when command-chain support requires it.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3296 in commit 95225991f, adding Snapcraft metadata generation of stub hooks for command-chain-based hooks. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3296 added command-chain hook stubs during metadata generation in commit 95225991f. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3296 in commit 95225991f, adding metadata-generated hook stubs needed for command-chain handling. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3296 adds command-chain hook stubs when required during metadata generation, updating three files (+88/-13). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged: implements command-chain stubs using hooks when needed. Approved by one reviewer, modifying three files with 88 additions and 13 deletions to update metadata generation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a pull request adding meta stubs for command-chain using hooks. Authored by maintainer sergiusens, the change was integrated directly into the codebase without additional review comments or revisions. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#3386
(confidence 98%)
Follow-up fix preserved existing primed hook scripts when generating stubs.
-
Related To:
snapcraft#2850
(confidence 90%)
Earlier merged PR enabled command-chain support for hooks.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3386 meta: don't overwrite preconfigured hooks with stubs | snapcraft | merged | Hook stub generation now preserves existing primed meta/hooks scripts; merged in snapcraft#3386 via commit bb9525144, with added unit-test fixtures and coverage. | |
| #1824255 snapcraft should use command-chain for hooks | snapcraft (launchpad) | closed | Fixed hook environment setup in merged #2897 (bfac28cea) by embedding the generated snap environment in hook wrappers; released in Snapcraft 3.10. | |
| #1797468 Add support for hook command-chains | snapcraft (launchpad) | closed | Hook command-chain support shipped in canonical/snapcraft#2850 (41c9fb464); LP #1797468 was later closed as stale after nearly eight years. | |
| #6433 Generated hooks are not included in the Snap | snapcraft | closed | Generated part hooks now replace stubs correctly; commit 271462658 prevents premature stub creation and was targeted for Snapcraft 9.1.3. | |
| #3659 meta: add support for hooks | snapcraft | merged | Merged snapcraft#3659 via commit 00eed7dc9 (merge 795294fd5) into snapcraft/7.0, adding hooks support in snapcraft.yaml for CRAFT-808. | |
| #6434 Replace generated hook stubs with built hooks when hooks are declared | snapcraft | closed | Closed unmerged; the generated-hook regression was fixed separately by commit 271462658 and released in Snapcraft 9.1.3. |