← Back to issue list

Fix rosdep ROS_PYTHON_VERSION

View original Github issue

Metadata

Project
snapcraft
Number
#3346
Type
pull request
State
merged
Author
artivis
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3346 (commit d388938c7) fixes the v1 ROS 2 colcon/rosdep path by setting ROS_PYTHON_VERSION=3.

Resolution: closed resolved

Reason: PR #3346 merged as commit d388938c7, correcting rosdep environment handling for ROS 2 by setting ROS_PYTHON_VERSION to 3.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Sets `ROS_PYTHON_VERSION=3` if `Rosdep` used for ROS 2 (colcon plugin V1). Signed-off-by: artivis <deray.jeremie@gmail.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3346 (commit d388938c7) fixes the v1 ROS 2 colcon/rosdep path by setting ROS_PYTHON_VERSION=3.
stealth/space-bunny-alpha — closed resolved Merged PR #3346 (commit d388938c7) sets ROS_PYTHON_VERSION=3 in the v1 rosdep plugin for ROS 2, fixing the underlying behavior rather than merely silencing its warning.
qwen/qwen3.6-35b-a3b — — Merged. Sets ROS_PYTHON_VERSION to 3 for ROS 2 rosdep usage, correcting underlying behavior rather than merely silencing warnings. Approved by reviewers and merged following low-risk assessment.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for rosdep ROS_PYTHON_VERSION in the ROS 2 colcon plugin V1. Sets the variable to 3 to resolve warnings and correct bad behavior, superseding a previous incomplete fix. Approved as low risk.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3324 (confidence 99%)

    Earlier merged PR #3324 set ROS_PYTHON_VERSION incorrectly for ROS 2; #3346 corrected it to 3.

Related issues

Issue Project State Summary Similarity
#3324 set ROS_PYTHON_VERSION for rosdep snapcraft merged Merged PR #3324 (commit 886da09ca) set ROS_PYTHON_VERSION=2 for rosdep, eliminating the unset-variable warning. PR #3346 later refined ROS 2 handling to use version 3.
82%