← Back to issue list

Create an extra 'build' directory for plugins

View original Github issue

Metadata

Project
snapcraft
Number
#3347
Type
pull request
State
closed
Author
artivis
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged in favor of #3392, which added v2 plugin out-of-source builds by skipping source copying; merged as commit 21c486876.

Resolution: closed superseded

Reason: Maintainers agreed to continue with #3392 and close this proposal. PR #3392 later merged as commit 21c486876, adding an out_of_source_build property for v2 plugins.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR introduces an extra 'build' directory `part-name/build_plugin` (and associated env var `SNAPCRAFT_PART_BUILD_PLUGIN`) for plugins that may need it. This comes from the need to isolate the source files root directory (`part-name/build`) from the build artifacts for the ROS plugins. Signed-off-by: artivis <deray.jeremie@gmail.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #3392, which added v2 plugin out-of-source builds by skipping source copying; merged as commit 21c486876.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #3392, which added v2 out-of-source builds; ROS plugins adopted the alternative in #3405.
qwen/qwen3.6-35b-a3b — — Closed and superseded in favor of PR #3392. Maintainers preferred implementing a source copy flag or property for out-of-tree builds instead of adding a dedicated build_plugin directory.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #3392. Maintainers preferred a flag to skip copying sources to the build directory over the proposed extra build folder. The PR was closed to pursue the alternative approach.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3392 (confidence 100%)

    Merged replacement implementing clean out-of-source builds instead of adding a plugin-specific build directory.

Related issues

No related issues found above the similarity threshold.