← Back to issue list

Redo pkg-config handling with library collecting

View original Github issue

Metadata

Project
snapcraft
Number
#335
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Redoes pkg-config handling for library collecting and implements ELF dependency tracking from host to snap. Approved after integration tests passed, with known sudo/armhf test failures deferred for a future release.

Suggested action:

No scores available.

Issue body

pkg-config only handled PKG_CONFIG_SYSROOT_DIR as the stage dir providing many issues when using packages from installdir for a part and also build-packages from the host. For a full implementation, elf dependency tracking from the host to the snap is also implemented here LP: #1549570 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Redoes pkg-config handling for library collecting and implements ELF dependency tracking from host to snap. Approved after integration tests passed, with known sudo/armhf test failures deferred for a future release.
qwen3.6-35b-a3b-mtp-q6 Merged after unit tests passed. Redoes pkg-config handling with library collecting, resolving PKG_CONFIG_SYSROOT_DIR issues and adding ELF dependency tracking from host to snap. Deferred armhf integration test sudo failures.
qwen3.6-35b-a3b-mtp-q6 Merged. Redoes pkg-config handling with library collecting and implements ELF dependency tracking from host to snap. Approved after integration tests passed, with deferred fixes for sudo-related armhf failures.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#75 refactor: rewrite elf file support debcraft merged Merged rewrite of ELF file support to better match deb building needs, replacing Snapcraft's implementation. Handles needed libraries; symbol support deferred. Approved by two reviewers, passed all CI checks, and resolves #72.
72%
#2126 packaging: load the correct libraries on armhf snapcraft merged Merged fix to snapcraft packaging to correctly load armhf libraries via ctypes dlopen, resolving architecture-specific runtime issues. Approved by reviewer and passed CI checks.
70%