← Back to issue list

Redo pkg-config handling with library collecting

View original Github issue

Metadata

Project
snapcraft
Number
#335
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#335 as commit 4a5de243e, reworking pkg-config sysroot handling and adding host-to-snap ELF dependency collection.

Resolution: closed resolved

Reason: The PR was merged after maintainer testing. Commit 4a5de243e implements the pkg-config overhaul and library dependency collection needed for host and part packages.

Evaluated by: mr-cal-bot

No scores available.

Issue body

pkg-config only handled PKG_CONFIG_SYSROOT_DIR as the stage dir providing many issues when using packages from installdir for a part and also build-packages from the host. For a full implementation, elf dependency tracking from the host to the snap is also implemented here LP: #1549570 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#335 as commit 4a5de243e, reworking pkg-config sysroot handling and adding host-to-snap ELF dependency collection.
stealth/space-bunny-alpha — closed resolved Merged PR #335 as commit 4a5de243e, reworking pkg-config sysroot handling and adding ELF dependency collection from host libraries into the snap.
stealth/space-bunny-alpha — closed resolved Merged as snapcraft commit 4a5de243e via #335, reworking pkg-config stage-dir handling and adding host-to-snap ELF dependency collection.
qwen/qwen3.6-35b-a3b — — Merged. Redoes pkg-config handling for library collecting and implements ELF dependency tracking from host to snap. Approved after integration tests passed, with known sudo/armhf test failures deferred for a future release.
qwen3.6-35b-a3b-mtp-q6 — — Merged after unit tests passed. Redoes pkg-config handling with library collecting, resolving PKG_CONFIG_SYSROOT_DIR issues and adding ELF dependency tracking from host to snap. Deferred armhf integration test sudo failures.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#620 Alter prefix for pkg-config to get correct values snapcraft merged Merged in snapcraft#620 as commit f25abf9c0, correcting pkg-config prefixes so reported values resolve correctly during builds.
71%
#3848 repo: fix_pkg_config removes prefixes from staged snap's .pc files. snapcraft merged Merged in snapcraft#3848 as commit 2dadaa6da, fixing fix_pkg_config to remove build-stage prefixes from staged snaps' pkg-config .pc files.
70%