← Back to issue list

repo: apt sources management refactor

View original Github issue

Metadata

Project
snapcraft
Number
#3363
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged refactor of apt sources management. Migrated to AptSourcesManager, removed PackageRepository install interfaces, and updated project loader. No behavioral changes. Approved, passed CI, +0.06% coverage.

Suggested action:

No scores available.

Issue body

- Finish removing install interfaces from PackageRepository. - Migrate apt sources configuration from _deb.Ubuntu to apt_sources_manager.AptSourcesManager. - Update project loader to use AptSourcesManager. There should be no change in behavior. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged refactor of apt sources management. Migrated to AptSourcesManager, removed PackageRepository install interfaces, and updated project loader. No behavioral changes. Approved, passed CI, +0.06% coverage.
qwen3.6-35b-a3b-mtp-q6 Merged refactor of apt sources management. Migrated configuration from _deb.Ubuntu to AptSourcesManager, updated project loader, and removed install interfaces from PackageRepository. No behavioral changes. Merged into master.
qwen3.6-35b-a3b-mtp-q6 Merged PR #3363 refactored apt sources management by migrating configuration to AptSourcesManager and removing install interfaces from PackageRepository. Updated the project loader with no behavioral changes. Code coverage increased by 0.06%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3647 repo: add package repository handling (CRAFT-846) snapcraft merged Merged into main. Introduces apt repository and PPA handling definitions and helpers, consolidated from multiple prior pull requests. Approved by reviewers, passed all CI checks, and increased test coverage.
72%
#3030 repo: drop _AptCache and add migrate to install_stage_packages() snapcraft merged Merged refactoring removing _AptCache and consolidating repo logic into install_stage_packages(). Uses system apt cache for performance, updates tests, and migrates ROS plugins. Approved; +490/-1009 lines across 18 files.
71%
#57 repo: unify package repository representations craft-archives merged Merged. Consolidates package_repositories and projects modules into a unified model. Removes duplicate Apt classes, switches validation to Pydantic errors, and consolidates tests. Approved and merged after passing CI checks.
70%