← Back to issue list

project loader: purge dead code in Config

View original Github issue

Metadata

Project
snapcraft
Number
#3382
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged to master following maintainer approval. The change removes the unused stage_env() function and its unit test from the project loader config, eliminating 91 lines of dead code. CI checks passed and code coverage remained stable.

Suggested action:

No scores available.

Issue body

stage_env() does not appear to be used anywhere. Purge it along with associated unit test.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to master following maintainer approval. The change removes the unused stage_env() function and its unit test from the project loader config, eliminating 91 lines of dead code. CI checks passed and code coverage remained stable.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Removed the unused stage_env function and its unit test from the project loader Config. Updated per reviewer feedback and passed code coverage checks.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the unused stage_env() function and its unit test from the project loader Config. Maintainer requested an update prior to merge. Diff coverage achieved 100%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3364 project loader: ensure all key assets are utilized snapcraft merged Merged into master. Updates the project loader to raise an error when key assets are unutilized. Approved by a reviewer, passed CI checks, and integrated despite a minor coverage decrease.
70%