← Back to issue list

Copy entire source, even if source-subdir is specified.

View original Github issue

Metadata

Project
snapcraft
Number
#344
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #344 copies the complete source when source-subdir is set, then builds from that subdirectory, fixing LP #1549676.

Resolution: closed resolved

Reason: PR #344 was merged into main via merge commit 27e36feed. Implementation commit 6beb6fec6 changed source handling so the full tree remains available while building from the specified subdirectory.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently, if source-subdir is specified, Snapcraft copies ONLY that subdir (and excludes the rest of the source) and attempts to build from it. This only works for some projects, not all. A better solution is to copy the entire source and simply build from WITHIN the subdir. This PR fixes LP: [#1549676](https://bugs.launchpad.net/snapcraft/+bug/1549676) by introducing exactly that change. It does so without changing the plugin API or semantics.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #344 copies the complete source when source-subdir is set, then builds from that subdirectory, fixing LP #1549676.
stealth/space-bunny-alpha — closed resolved Merged in #344: Snapcraft now copies the full source even with source-subdir, then builds from the selected directory, fixing LP #1549676.
qwen/qwen3.6-35b-a3b — — Merged a fix that copies the entire source directory when source-subdir is specified, resolving build failures for projects requiring full source access. Approved after cosmetic review adjustments and verified via local tests.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix copying the full source directory instead of only the specified subdirectory when source-subdir is set, resolving build failures. Approved after style feedback and local testing, this resolves Launchpad bug #1549676 without API changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#349 Backport to 1.x: Copy entire source, even if source-subdir is specified. snapcraft merged Merged into 1.x via #349, backporting #344 so Snapcraft copies the entire fetched source while using source-subdir to select the build directory.
72%