← Back to issue list

python v2 plugin: install wheel for build environment

View original Github issue

Metadata

Project
snapcraft
Number
#3440
Type
pull request
State
closed
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #3440 (install wheel into <part-dir>/python-build-extras + PYTHONPATH for LP #1912244) was closed unmerged on 2021-03-01 by its author, replaced by PR #3453, merged as commit 166b68fdb defaulting v2 python-packages to pip, setuptools, wheel.

Resolution: closed superseded

Reason: Author cjp256 explicitly closed #3440 with the comment "replaced with https://github.com/snapcore/snapcraft/pull/3453" (2021-03-01). #3453 merged as commit 166b68fdb ("python v2 plugin: default python-packages to [pip, setuptools, wheel]"), delivering the same LP #1912244 fix via a cleaner approach that honours user overrides instead of a separate python-build-extras dir and PYTHONPATH injection.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Install wheel library into `<part-dir>/python-build-extras` and update PYTHONPATH to include libraries installed there. This way pip will have wheel installed and available: (1) preventing a really ugly build error (2) not polluting the installed components LP: #1912244 Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #3440 (install wheel into <part-dir>/python-build-extras + PYTHONPATH for LP #1912244) was closed unmerged on 2021-03-01 by its author, replaced by PR #3453, merged as commit 166b68fdb defaulting v2 python-packages to pip, setuptools, wheel.
stealth/space-bunny-alpha — closed superseded Closed in favor of #3453, which merged as 166b68fdb and made wheel a default python package for the v2 Python plugin, resolving LP #1912244.
qwen/qwen3.6-35b-a3b — — Superseded by PR #3453. The proposal to install wheel in the Python v2 plugin build environment to prevent build errors was replaced with an alternative implementation.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #3453. The wheel installation proposal was replaced after maintainers suggested alternative implementation approaches.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#3453 (confidence 99%)

    Author's closing comment names #3453 as the replacement; the superseding approach discussed in the review thread (sergiusens' option (d)).

  • Related To: snapcraft#3453 (confidence 95%)

    Commit 166b68fdb confirmed in git log as the merge of #3453, implementing the LP #1912244 fix by defaulting python-packages rather than build-extras.

Related issues

Issue Project State Summary Similarity
#3453 python v2 plugin: default python-packages to [pip, setuptools, wheel] snapcraft merged Merged PR #3453 as commit 166b68fdb, defaulting Python v2 packages to pip, setuptools, and wheel while preserving user overrides.
73%
#883 python plugin: wheel and install in the proper order snapcraft merged Merged as commit 28103a243, fixing LP #1638389 by building Python wheels before installing them.
71%