← Back to issue list

storeapi: reduce the amount of constants and their meaning

View original Github issue

Metadata

Project
snapcraft
Number
#3442
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged after review and CI approval. Simplified storeapi URL constants to root URLs only, using full endpoint paths directly. Renamed constants for backend alignment, reducing 55 lines across 13 files.

Suggested action:

No scores available.

Issue body

Simplify the use of constants to root urls only, using full endpoint paths where relevant. Rename the constants to reflect the backend naming for clarity. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after review and CI approval. Simplified storeapi URL constants to root URLs only, using full endpoint paths directly. Renamed constants for backend alignment, reducing 55 lines across 13 files.
qwen3.6-35b-a3b-mtp-q6 Merged changes that simplify storeapi URL constants to root URLs only, apply full endpoint paths where needed, and rename constants to match backend naming for improved clarity.
qwen3.6-35b-a3b-mtp-q6 Merged changes simplifying store API constants to root URLs only, using full endpoint paths where needed, and renaming constants to match backend naming for clarity.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3550 storeapi: log responses and registration error code snapcraft merged Merged. Adds debug logging for store API responses and improves registration error code output. The minimal change (+16/-5 lines, 4 files) passed CI, achieved 100% coverage, and was approved for backporting.
72%
#323 storeapi: reduce the mccabe complexity snapcraft merged Merged to reduce McCabe complexity in the storeapi module. The change modified three files, adding 89 and removing 78 lines. Approved by sergiusens, the author indicated subsequent work to replace static checks with flake8.
71%