storeapi: move http client and auth to http_clients package
Metadata
Current evaluation
Merged refactoring moving HTTP clients and auth logic to a new http_clients package. Migrates snapcraft.config.Config to an abstract base class, removes unused local credentials, and passes all reviews and CI.
Suggested action: —
No scores available.
Issue body
Move the existing http clients (UbuntuOneAuthClient and Client)
together with the agent logic into its own http_clients.
Corresponding errors (which still need redoing with a cetralized
strategy around the final request) to this package too.
Additionally, migrate snapcraft.config.Config to this package in the
form of a Abstract Base Class with a specific implementation for the
UbuntuOneAuthClient class.
While migrating config, the "local credentials" implementation was
removed as it was a feature brought in from the click_toolbelt days
and we never really exposed in Snapcraft.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring moving HTTP clients and auth logic to a new http_clients package. Migrates snapcraft.config.Config to an abstract base class, removes unused local credentials, and passes all reviews and CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Refactored storeapi by relocating HTTP clients, authentication logic, and config abstraction into a dedicated http_clients package. Dropped the unused local credentials implementation. Changes signed off by Sergio Schvezov. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Moved HTTP clients, auth logic, and agent code to a new http_clients package. Migrated snapcraft.config.Config to an abstract base class within it and removed the unused local credentials implementation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3592 storeapi: auth client for api.snapcraft.io | snapcraft | closed | Merged into master. The pull request adds an authentication client for api.snapcraft.io with a single-line change. Codecov reported 100% diff coverage with no overall coverage impact. Closed after successful merge. |