storeapi: move http client and auth to http_clients package
Metadata
Current evaluation
Merged in snapcraft#3472 (c32d76480), moving HTTP clients, auth, and agent logic into http_clients; Config became an ABC and unused local credentials were removed.
Resolution: closed resolved
Reason: PR #3472 was approved and merged as commit c32d76480, completing the storeapi refactor.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Move the existing http clients (UbuntuOneAuthClient and Client)
together with the agent logic into its own http_clients.
Corresponding errors (which still need redoing with a cetralized
strategy around the final request) to this package too.
Additionally, migrate snapcraft.config.Config to this package in the
form of a Abstract Base Class with a specific implementation for the
UbuntuOneAuthClient class.
While migrating config, the "local credentials" implementation was
removed as it was a feature brought in from the click_toolbelt days
and we never really exposed in Snapcraft.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#3472 (c32d76480), moving HTTP clients, auth, and agent logic into http_clients; Config became an ABC and unused local credentials were removed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as c32d76480: moved HTTP clients, authentication, agent logic, and related errors into http_clients; made Config an ABC and removed unused local credentials. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #3472 (commit c32d76480): HTTP clients, authentication and agent logic moved to http_clients; Config became an ABC, and unused local credentials were removed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring moving HTTP clients and auth logic to a new http_clients package. Migrates snapcraft.config.Config to an abstract base class, removes unused local credentials, and passes all reviews and CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Refactored storeapi by relocating HTTP clients, authentication logic, and config abstraction into a dedicated http_clients package. Dropped the unused local credentials implementation. Changes signed off by Sergio Schvezov. |
Update history
No update history recorded yet.
Related issues
No related issues found above the similarity threshold.