← Back to issue list

package-repositories: use last 8 characters of key id for .asc

View original Github issue

Metadata

Project
snapcraft
Number
#3486
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/snapcraft#3486 (commit 83d54e58a) by cjp256: snap/keys/*.asc package-repository key files now use the last 8 chars of the GPG key ID, aligning with gpg/apt-key. Fixes LP #1918967.

Resolution: closed resolved

Reason: The PR was merged into snapcraft as commit 83d54e58a ('package-repositories: use last 8 characters of key id for .asc (#3486)'), with review approved and 6 files changed (+5/-63). It resolves Launchpad bug #1918967.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Improves alignment with tools like gpg, apt-key, where the key short form is identified by its trailing bytes, rather than the leading bytes. LP: #1918967 Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/snapcraft#3486 (commit 83d54e58a) by cjp256: snap/keys/*.asc package-repository key files now use the last 8 chars of the GPG key ID, aligning with gpg/apt-key. Fixes LP #1918967.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#3486 (83d54e58a): .asc package-repository key files now use the last 8 characters of the GPG key ID, matching gpg and apt-key.
qwen/qwen3.6-35b-a3b — — Merged updates package-repositories to use the trailing 8 characters of GPG key IDs for .asc files, aligning with gpg and apt-key. Approved by two reviewers, passed CI, and modified six files.
qwen3.6-35b-a3b-mtp-q6 — — Merged a change to extract the last 8 characters of GPG key IDs for .asc files instead of the leading bytes, aligning with gpg and apt-key behavior. Resolves LP #1918967.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1918967 (confidence 90%)

    Upstream Launchpad bug #1918967 ('package-repositories key filename uses wrong end of fingerprint') closed by this fix, snapcraft.io docs updated.

  • Related To: snapcraft#3359 (confidence 55%)

    Earlier merged key management refactor that introduced the key-ID length validation and key filename handling this PR adjusts.

Related issues

Issue Project State Summary Similarity
#1918967 package-repositories key filename uses wrong end of fingerprint snapcraft (launchpad) closed Resolved on edge by snapcore/snapcraft#3486; key filenames now use the fingerprint’s last eight characters, and the documentation was updated.
72%