repo: fix regression in fix_symlink()
Metadata
Current evaluation
Merged PR #3497 as 405c57655, fixing fix_symlink() to relink host-copied files correctly and adding spread tests for relative and host-copy cases.
Resolution: closed resolved
Reason: The fix was merged into Snapcraft as commit 405c57655. It corrects copied-file symlinks and adds regression coverage.
Evaluated by: mr-cal-bot
No scores available.
Issue body
If the file was copied from host, the symlink was not updated
to point to the new file. It was logged as being copied, but
the copy wasn't utilized without a fixed (relative) symlink.
Add spread tests to cover relative and host copy cases.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3497 as 405c57655, fixing fix_symlink() to relink host-copied files correctly and adding spread tests for relative and host-copy cases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 405c57655, fixing fix_symlink() to update relative symlinks for host-copied files and adding spread tests for both cases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #3497 as commit 405c57655, fixing host-copied symlinks in fix_symlink() and adding relative/host-copy spread tests. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3497, merged as commit 405c57655, fixed a fix_symlink() regression for host-copied files, relinking copies and adding relative/host-copy spread tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for a regression in fix_symlink() where copied files retained stale symlinks. The update ensures symlinks correctly point to new files and adds spread tests for relative and host copy scenarios. Approved by two reviewers and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for a regression in fix_symlink() where symlinks failed to update to newly copied host files. The change ensures relative symlinks are correctly resolved and adds spread tests for relative and host copy scenarios. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3370 repo: address issue with fix_symlink() when pointed at directory | snapcraft | merged | PR #3370 merged as 44d5277a7: fix_symlink() now warns about dangling symlinks pointing at directories instead of crashing shutil.copyfile (SNAPCRAFT-2AV), plus refactor/docs. |