← Back to issue list

yaml: detect and log warning on duplicate keys in snapcraft.yaml

View original Github issue

Metadata

Project
snapcraft
Number
#3517
Type
pull request
State
closed
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Duplicate key detection and warnings for snapcraft.yaml were closed without review or merge. The implementation remains abandoned due to zero reviewer engagement and missing CI checks.

Suggested action:

No scores available.

Issue body

A very primitive check to warn if duplicate keys are found in the snapcraft.yaml. At the moment the file is loaded multiple times which may result in duplicate warnings (ha ha) which we need to address in future work. Given that there shouldn't be duplicates in YAML files, the extra verbosity should be OK. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Duplicate key detection and warnings for snapcraft.yaml were closed without review or merge. The implementation remains abandoned due to zero reviewer engagement and missing CI checks.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. The pull request proposed a primitive warning for duplicate keys in snapcraft.yaml but was abandoned due to potential duplicate warnings and lack of test coverage.
qwen3.6-35b-a3b-mtp-q6 Closed without merging. The duplicate key warning implementation for snapcraft.yaml was abandoned due to inactivity.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3518 yaml: detect and log warning on duplicate keys in snapcraft.yaml (CRAFT-553) snapcraft merged Merged into master after rebasing and approval. Adds a warning check for duplicate keys in snapcraft.yaml, logging all occurrences. Multiple warnings may trigger due to repeated file loads, to be optimized later.
88%