← Back to issue list

store: Add ReviewQueued status

View original Github issue

Metadata

Project
snapcraft
Number
#3556
Type
pull request
State
merged
Author
3v1n0
Labels
Created
Updated
Closed

Current evaluation

Merged a fix adding ReviewQueued to the allowed status enum for store revisions. This resolves a schema validation error causing snapcraft list-revisions to fail when encountering the new status. Approved and passed CI.

Suggested action:

No scores available.

Issue body

Another failure such as #3533 ``` snapcraft list-revisions joplin --arch=amd64 'ReviewQueued' is not one of ['Published', 'Unpublished', 'ManualReviewPending', 'NeedsInformation', 'AutomaticallyRejected', 'Rejected', 'ReviewInProgress'] Failed validating 'enum' in schema['properties']['revisions']['items']['properties']['status']: {'enum': ['Published', 'Unpublished', 'ManualReviewPending', 'NeedsInformation', 'AutomaticallyRejected', 'Rejected', 'ReviewInProgress'], 'introduced_at': 1, 'type': 'string'} On instance['revisions'][0]['status']: 'ReviewQueued' ``` - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix adding ReviewQueued to the allowed status enum for store revisions. This resolves a schema validation error causing snapcraft list-revisions to fail when encountering the new status. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged an update to the status enum that adds ReviewQueued, resolving a validation error during snap revision listing.
qwen3.6-35b-a3b-mtp-q6 Merged an external contribution adding ReviewQueued to the status enum, resolving a schema validation error that occurred when listing snap revisions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3533 store: Add ReviewInProgress status snapcraft merged Merged addition of the ReviewInProgress status to the store module. Addresses a discrepancy where the store returned this status but snapcraft rejected it. Approved by two reviewers with no unresolved comments.
83%
#1936247 `ReviewQueued` status breaks `revisions` output snapcraft (launchpad) closed Fixed and closed. Schema updated to include the ReviewQueued enum value, resolving the validation error that crashed snapcraft revisions.
81%
#2056 Fix formatting of some store errors snapcraft merged Merged after PR #2050 landed first. Fixed SnapcraftError formatting that crashed __str__ on pre-formatted strings with braces. Author rebased and added tests for StoreReviewError and StoreMetadataError fixes. Approved and passed CI.
71%