← Back to issue list

store: add API support for metrics (CRAFT-386)

View original Github issue

Metadata

Project
snapcraft
Number
#3559
Type
pull request
State
merged
Author
cjp256
Labels
—
Created
Updated
Closed

Current evaluation

PR #3559 (commit dd4784132, CRAFT-386) merged into master as 7dd2ad206, adding the /dev/api/snaps/metrics endpoint, package_metrics ACL token support and error helpers.

Resolution: closed resolved

Reason: Merged into master as commit 7dd2ad206 ("Merge pull request #3559 from cjp256/metrics-api"); the endpoint call at snapcraft/store/client.py:1023 and the package_metrics permission at client.py:270 are present in the tree.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- Add support for /dev/api/snaps/metrics endpoint. - Add ACL token support for package_metrics. - Add a couple of error helpers to format queries and error lists suited for get_details() section. It is handled a few different ways through the various exceptions and we should probably consolidate it some in the future. NOTE: requires re-login to gain appropriate permissions. Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #3559 (commit dd4784132, CRAFT-386) merged into master as 7dd2ad206, adding the /dev/api/snaps/metrics endpoint, package_metrics ACL token support and error helpers.
stealth/space-bunny-alpha — closed resolved Merged #3559 (dd47841) into master, adding Store API support for metrics, package_metrics ACL token handling, and error-formatting helpers.
qwen/qwen3.6-35b-a3b — — Merged into master. Adds API support for the metrics endpoint and ACL token handling for package metrics. Approved by reviewer, passed CI checks, and increased test coverage by 0.02%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Implements /dev/api/snaps/metrics endpoint support, package_metrics ACL tokens, and consolidated error formatting helpers. Achieved 98.52% diff coverage, increasing overall repository coverage by 0.02%.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3558 (confidence 85%)

    PR #3558 / commit 73fc79ff4 introduced the metrics data model (CRAFT-385) this API layer builds on; merged just prior

  • Related To: snapcraft#3560 (confidence 85%)

    Follow-up CLI PR 'cli: introduce metrics command' (commit 7b7673f78, CRAFT-387) consuming the new store API; merged as 1de3fab6d

  • Related To: snapcraft#3561 (confidence 70%)

    Follow-up store-metrics spread tests (commit 152e99adb), merged as 656fa8a4f

Related issues

Issue Project State Summary Similarity
#3560 cli: introduce metrics command (CRAFT-387) snapcraft merged Merged PR #3560, introducing snapcraft metrics with JSON/table output, required name and format arguments, and optional date ranges.
77%
#3558 storeapi: introduce data model module for metrics (CRAFT-385) snapcraft merged Merged #3558 via 6b133dac5, adding Store API data models for marshalling and unmarshalling metrics API requests and responses (CRAFT-385).
74%
#3549 [WIP] store: add metrics support snapcraft closed Closed unmerged as a WIP prototype; metrics support was reworked into #3558–#3561, whose model, API, CLI, and test changes were all merged.
71%