Remove the useles decode done in tests.
Metadata
Current evaluation
Merged PR #362 removed unnecessary UTF-8 decoding from captured but unused examples-test output in commit c6e0d5067.
Resolution: closed resolved
Reason: PR #362 was merged into main via merge commit 6d17a601d, applying commit c6e0d5067 to remove the unused decoding.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The examples tests shell out and capture output but this output
is not used so we should not decode it.
LP: #1552403
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #362 removed unnecessary UTF-8 decoding from captured but unused examples-test output in commit c6e0d5067. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #362 removed the unnecessary decoding of captured, unused output in examples tests. The one-line change was approved by @kyrofa. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a single-line change removing unnecessary string decoding from captured test output. Approved by @kyrofa and resolves LP: #1552403. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of redundant string decoding in test output capture. The shell command output was unused, making decoding unnecessary. Approved by @kyrofa and addressed in LP: #1552403. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #310 examples_tests: decode the output with utf-8 | snapcraft | merged | Merged in PR #310 via commit 4dc9f2638 (merge 8439e82ca), decoding examples-test output as UTF-8; Jenkins confirmed the decode errors disappeared. |