← Back to issue list

parts: add early base parsing (CRAFT-766)

View original Github issue

Metadata

Project
snapcraft
Number
#3631
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in 228fb6d63; PR #3631 added early project YAML base parsing for lifecycle commands, selecting new handlers for core22 and legacy handlers for other bases.

Resolution: closed resolved

Reason: PR #3631 was merged as commit 228fb6d63, with implementation commit c1e88db9b. It loads the project YAML early, validates core22, and falls back to legacy handlers for other bases.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Load the project YAML file to verify the base entry when a lifecycle command is used. If it's not core22, fall back to the legacy handlers. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in 228fb6d63; PR #3631 added early project YAML base parsing for lifecycle commands, selecting new handlers for core22 and legacy handlers for other bases.
stealth/space-bunny-alpha — closed resolved Merged into snapcraft/7.0, adding early project YAML/base parsing so non-core22 lifecycle projects use legacy handlers.
stealth/space-bunny-alpha — closed resolved Merged PR #3631 added early project-YAML base parsing for lifecycle commands, validating core22 and falling back to legacy handlers for other bases.
qwen/qwen3.6-35b-a3b — — Merged into snapcraft/7.0. Adds early base parsing for lifecycle commands, verifying the base entry via project YAML and falling back to legacy handlers if not core22. Approved, passed CI, +0.81% coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Implements early base parsing for lifecycle commands, verifying the project YAML base entry and falling back to legacy handlers if not core22. Coverage increased by 0.81%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#341 config: add short-form bases support (CRAFT-11) charmcraft merged Merged #341, adding short-form base support so a base string expands to matching build-on and run-on entries.
72%