grammar: migrate to external package (CRAFT-819)
Metadata
Current evaluation
Merged: grammar plugin moved out of the snapcraft tree into the external craft-grammar package (CRAFT-819), deleting ~2,439 lines. Merge commit 943d130c2.
Resolution: closed resolved
Reason: PR #3642 was approved and merged into snapcraft as commit 943d130c2, which contained e448600fa 'grammar: migrate to external package' removing the in-tree grammar implementation and depending on the external package instead.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged: grammar plugin moved out of the snapcraft tree into the external craft-grammar package (CRAFT-819), deleting ~2,439 lines. Merge commit 943d130c2. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3642 in commit 943d130c2, migrating grammar support to an external package and removing 2,439 lines of in-tree implementation. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged migration of grammar to an external package. Approved by reviewer, passed CI, and reduced codebase by over 2,300 lines across 24 files. A reported store upload failure was unrelated to these changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Migrated grammar to an external package per CRAFT-819. Passed tests with unchanged coverage. Successfully merged into the 7.0 branch despite a noted store upload limitation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3 grammar: import from Snapcraft (CRAFT-818) | craft-grammar | merged | Merged PR #3 (69a12dc) imported the grammar from Snapcraft, updated lint/type tooling, and decoupled GrammarProcessor from ProjectOptions. | |
| #1684 Vendor grammar logic into snapcraft | snapcraft | closed | Advanced grammar was extracted to craft-grammar and adopted by Snapcraft in #3642 (merge 943d130c2), superseding the planned in-tree refactor. | |
| #1500 grammar: move into project_loader | snapcraft | merged | Merged as ed332f0d4, moving the stage-package grammar package from snapcraft/internal/pluginhandler into project_loader — a pure relocation, part of the #1492 effort to make grammar reusable across snapcraft.yaml. | |
| #5462 docs: migrate 'Snapcraft advanced grammar' | snapcraft | merged | Merged the advanced grammar documentation migration in commit b7a56461b; follow-up #5468 restored the Read the Docs build in 0157e5b15. |