← Back to issue list

parts,repo: integrate package-repositories (CRAFT-847)

View original Github issue

Metadata

Project
snapcraft
Number
#3649
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged into the 7.0 branch following approval and CI checks. Integrates package-repositories support to configure host apt repositories based on snapcraft.yaml. Updates span 21 files with 447 additions and 29 deletions.

Suggested action:

No scores available.

Issue body

Add apt package repositories to the host system according to the `package-repositories` entry listed in snapcraft.yaml. Also add a separate set of spread tests for core22. These can be removed and integrated to the existing tests when better 22.04 support is added to the testing infrastructure and more options are implemented in the 7.0 branch. Note: The pydantic model for package repositories are very similar to the legacy internal classes used to manipulate deb and ppa repositories. We should investigate if these can be consolidated, moving manual validation of repository parameters to the pydantic model. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into the 7.0 branch following approval and CI checks. Integrates package-repositories support to configure host apt repositories based on snapcraft.yaml. Updates span 21 files with 447 additions and 29 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged into 7.0. Integrates snapcraft.yaml package-repositories entries to configure host apt repositories. Adds core22 spread tests and notes pydantic model consolidation. Code coverage dropped 1.45% upon merge.
qwen3.6-35b-a3b-mtp-q6 Merged into snapcraft/7.0, this update integrates package-repositories to automatically configure apt repositories on the host system based on snapcraft.yaml. It adds core22 spread tests and notes future pydantic model consolidation.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#217 repo: add support for package repositories rockcraft merged Added support for package repositories. Merged after approval by two reviewers and passing CI checks. Modified 16 files (+346/-31), resolving CRAFT-1553 and enabling downstream testing.
75%
#3647 repo: add package repository handling (CRAFT-846) snapcraft merged Merged into main. Introduces apt repository and PPA handling definitions and helpers, consolidated from multiple prior pull requests. Approved by reviewers, passed all CI checks, and increased test coverage.
75%
#3 move "repo" code from snapcraft craft-archives closed Merged after approval, moving the snapcraft.repo package and tests to craft_archives. Updates include switching to loggers, adding a base error class, copying utility packages, and applying stricter linting fixes.
72%