← Back to issue list

parts: raise error when duplicate keys are used

View original Github issue

Metadata

Project
snapcraft
Number
#3669
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #3669 via a40a34314, adding parts.yaml_utils and safe YAML loading that rejects duplicate mapping keys. Follow-up #3670 repaired an unrelated spread-test issue.

Resolution: closed resolved

Reason: PR #3669 was merged as commit a40a34314 with merge commit ab5970540, implementing duplicate-key rejection for parts YAML. The author identified #3670 as the separate fix for a python-hello spread-test issue.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- Move yaml loading to a new module in the part package: yaml_utils - Forward port the safe loading implementation from legacy LP: #1942217 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- CRAFT-829

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #3669 via a40a34314, adding parts.yaml_utils and safe YAML loading that rejects duplicate mapping keys. Follow-up #3670 repaired an unrelated spread-test issue.
stealth/space-bunny-alpha — closed resolved Merged a safe YAML loader into parts/yaml_utils, rejecting duplicate keys and preventing ambiguous part configuration parsing.
qwen/qwen3.6-35b-a3b — — Merged. Refactored YAML loading into a new yaml_utils module and forward-ported safe loading to raise errors for duplicate keys in parts configuration. Approved by reviewer and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Refactors YAML loading into a new yaml_utils module within the part package, forward-porting safe loading from legacy to raise errors on duplicate keys. Addresses LP: #1942217 and CRAFT-829, with a related test fix in PR #3670.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#3670 (confidence 100%)

    Explicitly linked by the author as the fix for the spread-test issue; merged as d59a4c459.

Related issues

No related issues found above the similarity threshold.