← Back to issue list

parts: set up snap assets

View original Github issue

Metadata

Project
snapcraft
Number
#3702
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged in snapcraft#3702 as 8e2f28e (merge commit 2ccd3bdf5), adding snap asset setup: copying icon and desktop files into the payload and updating their executable and icon paths.

Resolution: closed resolved

Reason: PR #3702 was merged into the project as commit 8e2f28e, with merge commit 2ccd3bdf5. The merged change implements the requested desktop and icon asset handling.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Copy icon and desktop files to the snap payload and edit entries in the desktop file to point to the correct executables and icon files. Co-authored-by: Leo Arias <leo.arias@canonical.com> Co-authored-by: Chris Patterson <chris.patterson@canonical.com> Co-authored-by: Sergio Schvezov <sergio.schvezov@canonical.com> Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? ----- CRAFT-1039

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in snapcraft#3702 as 8e2f28e (merge commit 2ccd3bdf5), adding snap asset setup: copying icon and desktop files into the payload and updating their executable and icon paths.
stealth/space-bunny-alpha — closed resolved Merged #3702 as commit 8e2f28e into snapcraft/7.0, adding snap assets support: copies icon and desktop files into the snap payload and rewrites their Exec/Icon paths (CRAFT-1039).
stealth/space-bunny-alpha — closed resolved Merged #3702 in 8e2f28e, adding snap assets by copying icon and desktop files into the payload and correcting their executable and icon paths.
qwen/qwen3.6-35b-a3b — — Merged changes to set up snap assets by copying icon and desktop files to the payload and updating their paths. Approved by one reviewer, passed CI checks, and increased coverage by 0.49%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0. Configured snap assets by copying icon and desktop files to the payload and updating paths to correct executables and icons. Increased overall coverage by 0.49%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1560969 Support setup for gui assets snapcraft (launchpad) closed GUI assets were set up by convention, deprecating explicit icon declaration; resolved by ubuntu-core/snapcraft#399 (commit 5a099d295).
70%