← Back to issue list

repo: get host architecture using non-legacy code

View original Github issue

Metadata

Project
snapcraft
Number
#3707
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged into snapcraft/7.0. Replaced the legacy host architecture detection hook with the OsPlatform class. Approved by reviewer, passed CI, and modified two files with a net reduction of five lines.

Suggested action:

No scores available.

Issue body

Remove legacy hook to obtain host architecture, use OsPlatform instead. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into snapcraft/7.0. Replaced the legacy host architecture detection hook with the OsPlatform class. Approved by reviewer, passed CI, and modified two files with a net reduction of five lines.
qwen3.6-35b-a3b-mtp-q6 Merged into snapcraft/7.0. Replaced the legacy host architecture detection hook with OsPlatform. Codecov noted a 0.02% overall coverage decrease but confirmed 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into snapcraft/7.0. Replaced the legacy host architecture detection hook with OsPlatform. Code coverage decreased by 0.01% while maintaining 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3646 utils: gracefully determine host os (CRAFT-845) snapcraft merged Merged into snapcraft/7.0. Adds a class to parse /etc/os-release for graceful host OS detection and fallback when VERSION_CODENAME is unset. Forward-ported from prior work, approved, passed CI, and achieved 100% diff coverage.
75%