Fix/core20 ros plugin build failure should stop snapcraft
Metadata
Current evaluation
Merged #3745 (commit 4c5e29531), making ROS plugin-v2 build errors abort Snapcraft and adding regression tests for colcon, catkin, and catkin-tools.
Resolution: closed resolved
Reason: PR #3745 was merged as commit 4c5e29531. It explicitly preserves and restores Bash errexit in command substitutions and adds tests confirming ROS build failures stop Snapcraft.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
ROS plugin-v2 (colcon/catkin/catkin-tools) build error were not stopping snapcraft.
Bash turns off the `errexit` option in command substitutions, so we have to explicitly save the option in the saved state.
Added tests checking that it properly fails
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3745 (commit 4c5e29531), making ROS plugin-v2 build errors abort Snapcraft and adding regression tests for colcon, catkin, and catkin-tools. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3745 by Guillaumebeuzeboc merged (commit 4c5e2953, 2022-05-19) fixing ROS plugin-v2 (colcon/catkin) build errors not failing the snapcraft build, by saving/restoring errexit in command substitutions; added tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3745 (4c5e29531) to make ROS build failures stop Snapcraft by explicitly saving/restoring errexit in command substitutions. Added regression tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3745 (commit 4c5e29531) fixes ignored ROS plugin-v2 build errors by preserving Bash errexit, with regression tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #3745 made ROS plugin-v2 build errors stop Snapcraft by preserving Bash errexit in command substitutions; regression tests were added. Merge commit: 4c5e29531. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix ensuring ROS plugin build failures halt snapcraft. Bash disabled errexit in command substitutions, so the change explicitly saves and restores the option. Includes regression tests, passed CI, and received approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Fixes ROS plugin build failures not halting snapcraft by explicitly saving the bash errexit option, which was disabled in command substitutions. Includes regression tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1805213 Support the new ros2 build tool colcon | snapcraft (launchpad) | closed | Added and merged the beta colcon plugin for ROS 2 builds in snapcore/snapcraft#2456 (commit cd9516b56), resolving LP bug #1805213. |