Fix/core20 ros plugin build failure should stop snapcraft
Metadata
Current evaluation
Merged fix ensuring ROS plugin build failures halt snapcraft. Bash disabled errexit in command substitutions, so the change explicitly saves and restores the option. Includes regression tests, passed CI, and received approval.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
ROS plugin-v2 (colcon/catkin/catkin-tools) build error were not stopping snapcraft.
Bash turns off the `errexit` option in command substitutions, so we have to explicitly save the option in the saved state.
Added tests checking that it properly fails
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged fix ensuring ROS plugin build failures halt snapcraft. Bash disabled errexit in command substitutions, so the change explicitly saves and restores the option. Includes regression tests, passed CI, and received approval. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Fixes ROS plugin build failures not halting snapcraft by explicitly saving the bash errexit option, which was disabled in command substitutions. Includes regression tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix ensuring ROS plugin build failures halt snapcraft. Bash command substitutions previously disabled errexit, so the change explicitly saves and restores the option. Includes regression tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3536 ROS plugins v2 misc fixes | snapcraft | merged | Merged. Fixes ROS plugins v2 staging failures by checking local ROS directories and skipping rosdep resolution for locally available packages. Updated tests for core20. Approved by two reviewers and passed CI. | |
| #2965 rosdep: include EOL ROS distros | snapcraft | merged | Merged changes enabling snapcraft to build for end-of-life ROS distributions by adding a deprecation warning instead of failing. Approved and passed CI. |