← Back to issue list

parts: fix base package cutoff

View original Github issue

Metadata

Project
snapcraft
Number
#3769
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3769 in commit 25da6a72b, passing the effective build base to the parts processor so stage-package dependencies use the correct cutoff.

Resolution: closed resolved

Reason: PR #3769 was merged as 25da6a72b, with implementation commit b35585912. It fixes stage-package dependency cutoff to use the project-defined effective build base.

Evaluated by: mr-cal-bot

No scores available.

Issue body

When stage packages are installed dependencies should be cut at a threshold given by the base defined in the project. Pass the effective build base to the parts processor so that base package cutoff is performed at the correct threshold. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1096

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3769 in commit 25da6a72b, passing the effective build base to the parts processor so stage-package dependencies use the correct cutoff.
stealth/space-bunny-alpha — closed resolved Merged PR #3769, passing the effective build base into the parts processor so stage-package dependencies are cut off at the project-defined base threshold.
qwen/qwen3.6-35b-a3b — — Merged fix for base package cutoff. Passes effective build base to parts processor to correctly apply dependency thresholds for stage packages. Approved and merged into main.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix for stage package dependency cutoff. Passes effective build base to parts processor to correctly filter dependencies at the project-defined threshold. Integrated into main, increasing coverage by 0.10%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3729 parts: handle build base snapcraft merged Merged PR #3729 in commit 47f236f74, making parts honor declared build-base and fall back to the package name for base-type projects.
81%
#42 parts: enable stage package dependency cutoff rockcraft closed Merged PR #42 enabled craft-parts stage-package dependency cutoff and replaced distutils.util.strtobool locally, resolving the linter issue.
74%