← Back to issue list

parts: install dirmngr earlier

View original Github issue

Metadata

Project
snapcraft
Number
#3800
Type
pull request
State
closed
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

PR #3800 (parts: install dirmngr earlier, +11/-5) was closed unmerged by sergiusens in favour of #3801, which was merged to main as 38e2a8db2 (CRAFT-1149) to install package-repository dependencies before use.

Resolution: closed superseded

Reason: Maintainer sergiusens commented "Closing in favor of #3801" on 2022-06-21; #3801 ("package repositories: ensure dependencies are installed before use") was merged as commit 38e2a8db2, delivering the same fix more generally.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If package repositories are specified, install prerequisite packages directly instead of extra build packages (it's too late). Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #3800 (parts: install dirmngr earlier, +11/-5) was closed unmerged by sergiusens in favour of #3801, which was merged to main as 38e2a8db2 (CRAFT-1149) to install package-repository dependencies before use.
stealth/space-bunny-alpha — closed superseded Closed unmerged in favor of #3801, which was merged as 38e2a8db2 to install package-repository dependencies before use.
qwen/qwen3.6-35b-a3b — — Superseded by pull request #3801. The changes to install dirmngr earlier were closed without merging, as the maintainer redirected the fix to the referenced PR.
qwen3.6-35b-a3b-mtp-q6 — — Closed and superseded by pull request #3801. The dirmngr installation timing fix for specified package repositories was implemented in the referenced PR instead.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3801 (confidence 97%)

    Closing comment names #3801 as the preferred change; it was merged as 38e2a8db2 (CRAFT-1149).

  • Related To: canonical/snapcraft#3294 (confidence 45%)

    Earlier commit e4a013fd4 installed dirmngr before configuring package repositories — the same area of code, and an ancestor of this fix.

Related issues

Issue Project State Summary Similarity
#3293 project loader: install dirmngr prior to configuring package repositories snapcraft closed Closed unmerged because identical fix snapcraft#3294 merged in commit e4a013fd4, installing dirmngr and gnupg before configuring package repositories.
74%
#3294 project loader: install dirmngr prior to configuring package repositories snapcraft merged Merged PR #3294 (e4a013fd4), installing dirmngr and gnupg before package-repository setup so Launchpad builds have the required GPG tooling.
72%