← Back to issue list

fix(colcon-core18-test): use underscore instead of dash

View original Github issue

Metadata

Project
snapcraft
Number
#3818
Type
pull request
State
merged
Author
Guillaumebeuzeboc
Labels
—
Created
Updated
Closed

Current evaluation

Merged #3818 as c44b15203, updating the core18 colcon spread test to use an underscore instead of a dash after a colcon-core change.

Resolution: closed resolved

Reason: PR #3818 was approved and merged. Commit c44b15203 applies the two-file test naming fix required by colcon/colcon-core#518.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- Due to a recent update on colcon-core: https://github.com/colcon/colcon-core/issues/518

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #3818 as c44b15203, updating the core18 colcon spread test to use an underscore instead of a dash after a colcon-core change.
stealth/space-bunny-alpha — closed resolved Merged #3818 in commit c44b15203, replacing a dash with an underscore in the colcon-core18 test to match upstream colcon-core changes.
qwen/qwen3.6-35b-a3b — — Merged a fix replacing a dash with an underscore in colcon-core18 tests to align with upstream colcon-core changes. Approved, passed CI, and merged without coverage impact.
qwen3.6-35b-a3b-mtp-q6 — — Merged a test fix replacing a dash with an underscore to align with recent colcon-core updates. The change passed all checks, maintained existing code coverage, and was successfully integrated into the main branch.

Update history

No update history recorded yet.

Related work

  • Caused By: colcon-core#518 (confidence 95%)

    The PR body identifies this colcon-core change as the reason for using an underscore.

  • Related To: snapcraft#3817 (confidence 90%)

    Merged commit 6e0406199 temporarily moved Ubuntu 18.04 colcon spread tests to manual.

Related issues

Issue Project State Summary Similarity
#3817 spread: set colcon for 18.04 to manual snapcraft merged Merged #3817 as commit 6e0406199, temporarily marking the Ubuntu 18.04 colcon spread test manual until its code or test was fixed.
72%