← Back to issue list

cli: add KeyAlreadyExists error

View original Github issue

Metadata

Project
snapcraft
Number
#3844
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3844 via commit ef3318398 added KeyAlreadyExistsError handling so create-key reports existing local keys clearly, with additional store API error tests.

Resolution: closed resolved

Reason: PR #3844 was merged as commit ef3318398, implementing the create-key duplicate-key error and associated unit tests for CRAFT-1161 and Launchpad bug #1979907.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- #### Overview Raise new `KeyAlreadyExists` error when `snapcraft create-key` attempts to create an existing key. #### Changes 1. Add new error `KeyAlreadyExists` 2. Add unit tests for some other `storeapi` errors. #### Source - https://bugs.launchpad.net/snapcraft/+bug/1979907 (CRAFT-1161)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3844 via commit ef3318398 added KeyAlreadyExistsError handling so create-key reports existing local keys clearly, with additional store API error tests.
stealth/space-bunny-alpha — closed resolved Merged PR #3844 added the KeyAlreadyExists error for create-key and expanded storeapi error tests, resolving CRAFT-1161 / Launchpad bug #1979907.
stealth/space-bunny-alpha — closed resolved Merged into release/7.1 in #3844 (commit ef3318398), adding KeyAlreadyExists for create-key attempts involving an existing key, with storeapi error tests.
qwen/qwen3.6-35b-a3b — — Merged to release/7.1. Introduces a KeyAlreadyExists error for snapcraft create-key when generating an existing key, plus unit tests. Approved and passed CI.
qwen3.6-35b-a3b-mtp-q6 — — Merged after retargeting to the release/7.1 branch. Introduces a KeyAlreadyExists error to prevent duplicate key creation in snapcraft create-key, with corresponding unit tests.

Update history

No update history recorded yet.

Related issues

No related issues found above the similarity threshold.