← Back to issue list

linters: add missing library linter

View original Github issue

Metadata

Project
snapcraft
Number
#3872
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3872 as c5f4d8b53, adding a linter for missing ELF payload dependencies and fixing filename filtering in the classic linter.

Resolution: closed resolved

Reason: PR #3872 was approved and merged into main as commit c5f4d8b53. It added LibraryLinter with tests and corrected classic-linter filename filtering.

Evaluated by: mr-cal-bot

No scores available.

Issue body

List any missing ELF dependencies in the payload directory. Also fix filename filtering in classic linter. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1247

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3872 as c5f4d8b53, adding a linter for missing ELF payload dependencies and fixing filename filtering in the classic linter.
stealth/space-bunny-alpha — closed resolved Merged in #3872 via commit c5f4d8b53, adding detection for missing ELF payload dependencies and fixing classic-linter filename filtering.
stealth/space-bunny-alpha — closed resolved Merged in #3872 via commit c5f4d8b53, adding detection for missing ELF payload libraries and fixing classic-linter filename filtering.
stealth/space-bunny-alpha — closed resolved PR #3872 (CRAFT-1247) was merged as commit c5f4d8b53, adding snapcraft/linters/library_linter.py plus elf_utils to report missing ELF dependencies in the payload, and fixing filename filtering in the classic linter.
stealth/space-bunny-alpha — closed resolved Merged in #3872 (commit c5f4d8b53), adding a linter for missing ELF payload dependencies and fixing classic-linter filename filtering.
qwen/qwen3.6-35b-a3b — — Merged changes add a missing library linter to list ELF dependencies in the payload directory and fix filename filtering in the classic linter. Approved, passed CI, and increased coverage by 0.02%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Implemented a missing library linter to list ELF dependencies in the payload directory and fixed filename filtering in the classic linter. Coverage increased by 0.02%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3989 linters: don't list dynamic linker as missing library snapcraft merged Merged PR #3989 fixed the library linter so it no longer reports the dynamic linker as a missing library; landed as commit 97ce08c66.
80%
#3849 linters: add classic confinement linter snapcraft merged Merged #3849 in commit 82cf4c1d4, adding a classic-confinement linter for ELF interpreter, rpath, and staged-libc issues.
78%
#4028 linters: add linter check for unused libraries snapcraft merged Merged PR #4028 as commit e82a4434d, adding a linter warning when a snap packages a library that is not used.
73%
#3978 linters: fix classic linter interpreter warning snapcraft merged Merged #3978 into hotfix/7.2 via 06ca48442, limiting the classic-linter interpreter check to files that contain an interpreter section.
72%
#4077 linters: allow "categories" for subfiltering snapcraft merged Merged PR #4077 in commit 50722d144, adding category-level lint filtering and LibraryLinter's unused-library and missing-library categories.
71%