← Back to issue list

linters: add missing library linter

View original Github issue

Metadata

Project
snapcraft
Number
#3872
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged changes add a missing library linter to list ELF dependencies in the payload directory and fix filename filtering in the classic linter. Approved, passed CI, and increased coverage by 0.02%.

Suggested action: —

No scores available.

Issue body

List any missing ELF dependencies in the payload directory. Also fix filename filtering in classic linter. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1247

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged changes add a missing library linter to list ELF dependencies in the payload directory and fix filename filtering in the classic linter. Approved, passed CI, and increased coverage by 0.02%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Implemented a missing library linter to list ELF dependencies in the payload directory and fixed filename filtering in the classic linter. Coverage increased by 0.02%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into main. Added a missing library linter to track ELF dependencies in the payload directory and corrected filename filtering in the classic linter. The update increased overall code coverage by 0.02%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3849 linters: add classic confinement linter snapcraft merged Merged addition of a classic confinement linter warning about incorrect elf binary interpreter or rpath values and staged libc. Adjusts existing elf infrastructure, passed review and CI, was rebased on main, and increased code coverage.
80%
#4430 feat(linter): show missing libraries corresponding package snapcraft merged Merged into main. Enhances the linter to show the corresponding package for missing libraries. Approved by two reviewers, passed CI, and modified 3 files with 154 additions and 4 deletions.
76%
#3989 linters: don't list dynamic linker as missing library snapcraft merged Merged into hotfix/7.2. Updated the linter to exclude the dynamic linker from missing library warnings, resolving false positive linker errors. Approved and passed CI.
75%
#3931 linters: allow ignoring files per-linter snapcraft merged Merged. Restructures lint.ignore to support per-linter file exclusions for finer-grained control. Approved, passed CI with 100% diff coverage, and modified 9 files. Preserves ability to disable entire linters.
74%
#3978 linters: fix classic linter interpreter warning snapcraft merged Merged into hotfix/7.2. Resolves a classic linter interpreter warning by conditionally verifying the interpreter section. Approved, passed CI, and achieved 100% diff coverage.
73%
#4028 linters: add linter check for unused libraries snapcraft merged Merged following reviewer approval and successful CI checks. Adds a linter warning to flag unused libraries packaged into snaps. The update modifies 22 files with 449 additions and 40 deletions across five commits.
72%
#2746 elf: handle missing dependencies not found on system snapcraft merged Merged updates to handle missing ELF dependencies when ldd fails to resolve them. The change prevents filtering unresolved libraries, refactors ldd parsing for reliability, and adds unit tests. Approved by one reviewer and passed CI checks.
71%
#3847 linters: add linting infrastructure snapcraft merged Merged. Adds basic linting infrastructure to snapcraft, including a lint entry in snapcraft.yaml to disable specific linters before packing. JSON output is implemented for future use. Approved, rebased, and passed coverage checks.
71%
#4293 linters: specify which package offers a missing library snapcraft closed Superseded by PR #4430, which was merged. The library linter improvement was replaced by an updated implementation and the request was closed.
71%
#3672 linters: address issues and enable pylint in ci snapcraft merged Merged after approval and CI pass. The PR addressed linter issues and enabled pylint in CI across 8 files. Changes increased test coverage by 0.02% with 100% diff coverage, successfully integrating static analysis into the pipeline.
71%