store: on prem base client

Metadata

Project: snapcraft
Number: #3880
Type: pull request
State: merged
Author: sergiusens
Labels: —
Created: 2022-08-21 11:50 PM UTC
Updated: 2022-08-22 07:53 PM UTC
Closed: 2022-08-22 07:53 PM UTC

Current evaluation

Merged #3880 as commit 383b844ee, adding a craft-store-derived OnPrem base client and updating the legacy JSON decoder mock.

Resolution: closed resolved

Reason: PR #3880 was merged into main as commit 383b844ee, adding OnPrem store support and adjusting the legacy test mock for requests.JSONDecoder.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Derivation from craft-store's BaseClient to support the OnPrem store. This implementation is specific enough to Snapcraft to be implemented here. This includes an update to the test mock in legacy pertaining to the change of where JSONDecoder comes from now (requests). Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `pytest tests/unit`? ----- CRAFT-1243

Evaluation history

Date	Model	Scores	Action	Summary
2026-10-03 03:27 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged #3880 as commit 383b844ee, adding a craft-store-derived OnPrem base client and updating the legacy JSON decoder mock.
2026-10-03 03:27 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged the Snapcraft-specific OnPrem store BaseClient and legacy JSON decoder mock update in commit 383b844ee via PR #3880.
2026-09-25 01:43 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged in #3880 as commit 383b844ee, adding a craft-store-derived OnPrem base client and updating the legacy JSON decoder test mock.
2026-09-25 01:43 AM UTC	stealth/space-bunny-alpha	—	closed resolved	Merged into main as commit 383b844ee, adding an OnPrem store base client derived from craft-store and updating the legacy JSONDecoder mock.
2026-07-22 01:41 PM UTC	qwen/qwen3.6-35b-a3b	—	—	Merged into main. Adds an OnPrem base client derived from craft-store to support Snapcraft's on-premise store. Approved by reviewer, passed CI, and increased unit test coverage by 0.05%.
2026-07-18 02:39 AM UTC	qwen3.6-35b-a3b-mtp-q6	—	—	Merged, resolving CRAFT-1243. Adds an OnPrem store base client derived from craft-store's BaseClient, tailored for Snapcraft, with updated test mocks for JSONDecoder origin changes.

Update history

No update history recorded yet.

Related issues

Issue	Project	State	Summary	Similarity
#3885 store: initial support for an onprem store	snapcraft	merged	Merged initial on-premises store support for CRAFT-1228, landing as commit 260214788.	72%