← Back to issue list

cli: add legacy envvar for login and check stdin

View original Github issue

Metadata

Project
snapcraft
Number
#3889
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged into hotfix/7.1.3. Adds stdin closure check for login due to Launchpad logging changes and enables SNAPCRAFT_ENABLE_DEVELOPER_DEBUG for core22 projects. Approved with full coverage.

Suggested action: —

No scores available.

Issue body

Launchpad is no longer logging builds, we should allow for this by checking if stdin is closed or not. SNAPCRAFT_ENABLE_DEVELOPER_DEBUG is also analyzed for core22 projects which is useful for Snapcraft's own spread tests. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1231

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged into hotfix/7.1.3. Adds stdin closure check for login due to Launchpad logging changes and enables SNAPCRAFT_ENABLE_DEVELOPER_DEBUG for core22 projects. Approved with full coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.1.3. Implements a legacy login environment variable, stdin status checks, and SNAPCRAFT_ENABLE_DEVELOPER_DEBUG support for core22 projects. Coverage increased by 0.02%.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.1.3. Adds a legacy login environment variable, checks stdin status for Launchpad logging changes, and enables SNAPCRAFT_ENABLE_DEVELOPER_DEBUG for core22. Achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3493 cli: rename experimental login environment variable snapcraft merged Merged renaming the experimental login environment variable from SNAPCRAFT_LOGIN to avoid CI/CD conflicts. Approved by reviewer, passed CI, and integrated with a two-line change.
73%