← Back to issue list

cli: add legacy envvar for login and check stdin

View original Github issue

Metadata

Project
snapcraft
Number
#3889
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged into hotfix/7.1.3 as 72ad273f2. Adds legacy login envvar plus a closed-stdin check so builds work when Launchpad stops logging, and enables SNAPCRAFT_ENABLE_DEVELOPER_DEBUG for core22 (CRAFT-1231).

Resolution: closed resolved

Reason: The PR itself was merged by maintainer sergiusens into the 7.1.3 hotfix branch as commit 72ad273f2 (+87/-1, 3 files), with review approved and no unresolved comments, directly fixing the lack of build logging in Launchpad.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Launchpad is no longer logging builds, we should allow for this by checking if stdin is closed or not. SNAPCRAFT_ENABLE_DEVELOPER_DEBUG is also analyzed for core22 projects which is useful for Snapcraft's own spread tests. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- CRAFT-1231

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.1.3 as 72ad273f2. Adds legacy login envvar plus a closed-stdin check so builds work when Launchpad stops logging, and enables SNAPCRAFT_ENABLE_DEVELOPER_DEBUG for core22 (CRAFT-1231).
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.1.3 as 72ad273f2, adding a legacy login envvar and closed-stdin check for Launchpad builds, plus developer-debug support for core22.
qwen/qwen3.6-35b-a3b — — Merged into hotfix/7.1.3. Adds stdin closure check for login due to Launchpad logging changes and enables SNAPCRAFT_ENABLE_DEVELOPER_DEBUG for core22 projects. Approved with full coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.1.3. Implements a legacy login environment variable, stdin status checks, and SNAPCRAFT_ENABLE_DEVELOPER_DEBUG support for core22 projects. Coverage increased by 0.02%.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#3873 (confidence 92%)

    Author comment states this PR was 'originally #3873'; #3889 is the reworked version of that earlier backwards-compatible LP log enablement change (CRAFT-1231), and was redirected to the hotfix branch instead.

Related issues

Issue Project State Summary Similarity
#3493 cli: rename experimental login environment variable snapcraft merged Merged in commit 88e4f922f, renaming experimental login variable SNAPCRAFT_LOGIN to SNAPCRAFT_STORE_AUTH to avoid conflicts with CI/CD environment names.
72%